linux-kernel - Re: [PATCH -next] posix-clock: Fix missing put_clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8734ktai90.fsf@somnus>
Date: Fri, 18 Oct 2024 11:10:51 +0200
From: Anna-Maria Behnsen <anna-maria@...utronix.de>
To: Jinjie Ruan <ruanjinjie@...wei.com>, frederic@...nel.org,
 tglx@...utronix.de, richardcochran@...il.com, kuba@...nel.org,
 ruanjinjie@...wei.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] posix-clock: Fix missing put_clock_desc()

Hi,

Jinjie Ruan <ruanjinjie@...wei.com> writes:

> After get_clock_desc(), it should call put_clock_desc()
> if timespec64_valid_strict() check fails, put it ahead to avoid this.

Can you please rewrite the commit message so that it uses full sentences
and shortly explain the problem why get/put pair is required here? For
the subject I would propose to change it to: "posix-clock: Fix
unbalanced locking in pc_clock_settime()'.

The patch is no longer against next, as the change is already part of
linus tree.

The change itself looks good.

Thanks,

	Anna-Maria