linux-kernel - Re: [PATCHv2 4/5] crypto: cesa: move loop to mv_cesa_put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZxImX3HsbFHD7vSl@gondor.apana.org.au>
Date: Fri, 18 Oct 2024 17:11:59 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Rosen Penev <rosenp@...il.com>
Cc: linux-crypto@...r.kernel.org, Boris Brezillon <bbrezillon@...nel.org>,
	Arnaud Ebalard <arno@...isbad.org>,
	Srujana Challa <schalla@...vell.com>,
	"David S. Miller" <davem@...emloft.net>,
	Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCHv2 4/5] crypto: cesa: move loop to mv_cesa_put_sram

On Thu, Oct 10, 2024 at 12:45:16PM -0700, Rosen Penev wrote:
>
> @@ -566,21 +572,16 @@ static int mv_cesa_probe(struct platform_device *pdev)
>  	return 0;
>  
>  err_cleanup:
> -	for (i = 0; i < caps->nengines; i++)
> -		mv_cesa_put_sram(pdev, i);
> -
> +	mv_cesa_put_sram(pdev);

I think it'd be cleaner if you introduced a new function that
did the loop and kept mv_cesa_put_sram as is.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt