linux-kernel - Re: [linux-next:master 4889/5321] arch/powerpc/boot/dts/turris1x.dtb: reboot@d: {'compatible': ['syscon-reboot'], 'reg': [[13, 1]], 'offset': 13, 'mask': 1, 'value': 1, 'priority': 64, '$nodename': ['reboot@d']} is valid under each of {'required': ['re...

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <a1e2d600-207c-4bc4-9a00-7295e2748daa@alliedtelesis.co.nz>
Date: Fri, 18 Oct 2024 00:15:00 +0000
From: Chris Packham <Chris.Packham@...iedtelesis.co.nz>
To: Sebastian Reichel <sebastian.reichel@...labora.com>, Krzysztof Kozlowski
	<krzk@...nel.org>, "mpe@...erman.id.au" <mpe@...erman.id.au>
CC: "oe-kbuild-all@...ts.linux.dev" <oe-kbuild-all@...ts.linux.dev>,
	"linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [linux-next:master 4889/5321] arch/powerpc/boot/dts/turris1x.dtb:
 reboot@d: {'compatible': ['syscon-reboot'], 'reg': [[13, 1]], 'offset': 13,
 'mask': 1, 'value': 1, 'priority': 64, '$nodename': ['reboot@d']} is valid
 under each of {'required': ['re...


On 18/10/24 12:10, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head:   7df1e7189cecb6965ce672e820a5ec6cf499b65b
> commit: e7af7d13316dc5e2293c4f777f71bd8331f5d7a5 [4889/5321] dt-bindings: reset: syscon-reboot: Add reg property
> :::::: branch date: 11 hours ago
> :::::: commit date: 23 hours ago
> config: powerpc-randconfig-052-20241017 (https://download.01.org/0day-ci/archive/20241018/202410180305.ZFlGnzVB-lkp@intel.com/config)
> compiler: powerpc-linux-gcc (GCC) 14.1.0
> dtschema version: 2024.10.dev6+g12c3cd5
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241018/202410180305.ZFlGnzVB-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/r/202410180305.ZFlGnzVB-lkp@intel.com/
>
> dtcheck warnings: (new ones prefixed by >>)
>     arch/powerpc/boot/dts/turris1x.dtb: nor@0,0: $nodename:0: 'nor@0,0' does not match '^(flash|.*sram|nand)(@.*)?$'
>     	from schema $id: http://devicetree.org/schemas/mtd/mtd-physmap.yaml#
>     arch/powerpc/boot/dts/turris1x.dtb: /localbus@...05000/nand@1,0: failed to match any schema with compatible: ['fsl,p2020-fcm-nand', 'fsl,elbc-fcm-nand']
>     arch/powerpc/boot/dts/turris1x.dtb: /localbus@...05000/nand@1,0: failed to match any schema with compatible: ['fsl,p2020-fcm-nand', 'fsl,elbc-fcm-nand']
>     arch/powerpc/boot/dts/turris1x.dtb: cpld@3,0: $nodename:0: 'cpld@3,0' does not match '^([a-z][a-z0-9\\-]+-bus|bus|localbus|soc|axi|ahb|apb)(@.+)?$'
>     	from schema $id: http://devicetree.org/schemas/simple-bus.yaml#
>     arch/powerpc/boot/dts/turris1x.dtb: /localbus@...05000/cpld@3,0: failed to match any schema with compatible: ['cznic,turris1x-cpld', 'fsl,p1021rdb-pc-cpld', 'simple-bus', 'syscon']
>     arch/powerpc/boot/dts/turris1x.dtb: /localbus@...05000/cpld@3,0: failed to match any schema with compatible: ['cznic,turris1x-cpld', 'fsl,p1021rdb-pc-cpld', 'simple-bus', 'syscon']
>     arch/powerpc/boot/dts/turris1x.dtb: watchdog@2: Unevaluated properties are not allowed ('gpios' was unexpected)
>     	from schema $id: http://devicetree.org/schemas/watchdog/maxim,max63xx.yaml#
>>> arch/powerpc/boot/dts/turris1x.dtb: reboot@d: {'compatible': ['syscon-reboot'], 'reg': [[13, 1]], 'offset': 13, 'mask': 1, 'value': 1, 'priority': 64, '$nodename': ['reboot@d']} is valid under each of {'required': ['reg']}, {'required': ['offset']}

This will be because of my changes to add reg and the oneOf: offset, reg 
to syscon-reboot.yaml. Prior to this I'm guessing there was either a 
different warning or possibly just nothing since the unused property was 
"reg".

How do we want to handle this? I could probably change oneOf to anyOf in 
the schema which would silence the warning. Technically it should be 
fine to remove the reg property from the turris1x.dts as nothing was 
using that and even after my changes offset is used first. Or we could 
just do nothing which I'm fine with.

>     	from schema $id: http://devicetree.org/schemas/power/reset/syscon-reboot.yaml#
>     arch/powerpc/boot/dts/turris1x.dtb: /localbus@...05000/cpld@3,0/led-controller@13: failed to match any schema with compatible: ['cznic,turris1x-leds']
>     arch/powerpc/boot/dts/turris1x.dtb: pcie@...08000: pcie@0:interrupts:0:0: 24 is not one of [1, 2, 3, 4]
>     	from schema $id: http://devicetree.org/schemas/pci/pci-bus-common.yaml#
>     arch/powerpc/boot/dts/turris1x.dtb: pcie@...08000: pcie@0:interrupts:0: [24, 2, 0, 0] is too long
>     	from schema $id: http://devicetree.org/schemas/pci/pci-bus-common.yaml#
>     arch/powerpc/boot/dts/turris1x.dtb: /pcie@...08000: failed to match any schema with compatible: ['fsl,mpc8548-pcie']
>     arch/powerpc/boot/dts/turris1x.dtb: pcie@...09000: pcie@0:interrupts:0:0: 25 is not one of [1, 2, 3, 4]
>     	from schema $id: http://devicetree.org/schemas/pci/pci-bus-common.yaml#
>     arch/powerpc/boot/dts/turris1x.dtb: pcie@...09000: pcie@0:interrupts:0: [25, 2, 0, 0] is too long
>