linux-kernel - Re: [PATCH] ARM: dts: aspeed: Add device tree for Ampere's Mt. Jefferson BMC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <21065884-97c7-4815-9347-f4f03dff8c43@amperemail.onmicrosoft.com>
Date: Fri, 18 Oct 2024 17:08:29 +0700
From: Chanh Nguyen <chanh@...eremail.onmicrosoft.com>
To: Andrew Jeffery <andrew@...econstruct.com.au>,
 Chanh Nguyen <chanh@...amperecomputing.com>
Cc: Rob Herring <robh+dt@...nel.org>, Krzysztof Kozlowski
 <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 Joel Stanley <joel@....id.au>, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-aspeed@...ts.ozlabs.org,
 linux-kernel@...r.kernel.org, OpenBMC Maillist <openbmc@...ts.ozlabs.org>,
 Open Source Submission <patches@...erecomputing.com>,
 Phong Vo <phong@...amperecomputing.com>,
 Thang Nguyen <thang@...amperecomputing.com>,
 Quan Nguyen <quan@...amperecomputing.com>,
 Khanh Pham <khpham@...erecomputing.com>
Subject: Re: [PATCH] ARM: dts: aspeed: Add device tree for Ampere's Mt.
 Jefferson BMC

On 18/10/2024 11:34, Andrew Jeffery wrote:
> Hi Chanh,
> 
> On Mon, 2024-10-14 at 10:50 +0000, Chanh Nguyen wrote:
>>
>> +&mac3 {
>> +	status = "okay";
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&pinctrl_rmii4_default>;
>> +	clock-names = "MACCLK", "RCLK";
> 
> Should this be overriding `clocks` also? There's only one clock
> specified in the dtsi.
> 

Thank Andrew,
I think it is redundant config. I don't need to override the `clock` and 
`clock-names` here. The mac3 will use the clock specified in the dtsi.
I'll remove `clock-names` in the patch v2

Summary, I need to update as the below list.
1. Add Mt. Jefferson board compatible binding as Krzysztof pointed.
2. Remove the PSU node with "pmbus" compatible.
3. Remove `clock-names' property in mac3 node

Regards,
Chanh

> Andrew
> 
>> +	use-ncsi;
>> +};