linux-kernel - Re: [PATCH v2 5/5] phy: qcom: qmp-usbc: Add qmp configuration for QCS615

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <479f7aa2-0401-40d5-8e2f-d7512aeab0c0@quicinc.com>
Date: Fri, 18 Oct 2024 15:53:22 +0530
From: Krishna Kurapati <quic_kriskura@...cinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
CC: Vinod Koul <vkoul@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Rob Herring <robh@...nel.org>,
        Kishon Vijay Abraham I <kishon@...nel.org>,
        Bjorn Andersson <quic_bjorande@...cinc.com>,
        Wesley Cheng
	<quic_wcheng@...cinc.com>,
        Konrad Dybcio <konradybcio@...nel.org>,
        "Tingwei
 Zhang" <quic_tingweiz@...cinc.com>,
        Conor Dooley <conor+dt@...nel.org>,
        "Greg
 Kroah-Hartman" <gregkh@...uxfoundation.org>,
        Manivannan Sadhasivam
	<manivannan.sadhasivam@...aro.org>,
        <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-phy@...ts.infradead.org>, <quic_ppratap@...cinc.com>,
        <quic_jackp@...cinc.com>
Subject: Re: [PATCH v2 5/5] phy: qcom: qmp-usbc: Add qmp configuration for
 QCS615



On 10/18/2024 3:41 PM, Dmitry Baryshkov wrote:
> On Fri, Oct 18, 2024 at 05:01:48PM +0800, Tingwei Zhang wrote:
>> On 10/18/2024 4:06 PM, Dmitry Baryshkov wrote:
>>> On Fri, 18 Oct 2024 at 10:48, Tingwei Zhang <quic_tingweiz@...cinc.com> wrote:
>>>>
>>>> On 10/18/2024 2:27 AM, Dmitry Baryshkov wrote:
>>>>> On Thu, 17 Oct 2024 at 16:07, Krishna Kurapati
>>>>> <quic_kriskura@...cinc.com> wrote:
>>>>>>
>>>>>> Provide PHY configuration for the USB QMP PHY for QCS615 Platform.
>>>>>>
>>>>>> Signed-off-by: Krishna Kurapati <quic_kriskura@...cinc.com>
>>>>>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
>>>>>
>>>>> After checking platform details,
>>>>>
>>>>> Unreviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
>>>>>
>>>>> Please perform global s/QCS615/SM6150/ and s/qcs615/sm6150/
>>>>
>>>> QCS615 and SM6150 are different variants of the same SoC. QCS615 is an
>>>> IoT variant, while SM6150 is a mobile variant. We are currently adding
>>>> QCS615 SoC support to the upstream Kernel, as it is in an active
>>>> development stage and we anticipate many products based on this SoC. On
>>>> the other hand, the SM6150 is an older mobile platform that is unlikely
>>>> to be used in new designs. For a product introduction of the QCS615,
>>>> please refer to
>>>> https://docs.qualcomm.com/bundle/publicresource/87-83838-1_REV_A_Qualcomm_IQ6_Series_Product_Brief.pdf
>>>
>>> Yes, I guessed so. It would have been nice if it was documented this
>>> way from the beginning.
>>>
>>> Please note that we usually get support for the mobile SoC first. So
>>> in most of the cases devices use mobile compatible even for IoT
>>> platforms, see qrb5165, qrb4210, qcm6490 and other similar platforms.
>>> I simply asked to follow the established pattern.
>>
>> Yes, we start from mobile variant for most of the platforms. There are some
>> exceptions like sc7180 and sc7280 which we started from compute variant
>> since they are widely used by compute platform on upstream Kernel. I think
>> we have similar case here. QCS615 will be widely used by IOT products on
>> upstream Kernel. We should have clarified this from beginning so there's no
>> ambiguity.
> 
> After offline discussion with Krzysztof, I'll lift my objection, so
> still Reviewed-by.
> 

Thanks Dmitry.

Can you help review patch-4 of the series. I made the changes you 
suggested on v1 (uppercase to lowercase and removing un-necessary re-inits).

Regards,
Krishna,