linux-kernel - Re: [PATCH] HID: i2c-hid: Delayed i2c resume wakeup for Goodix touchpads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.2410181230300.20286@cbobk.fhfr.pm>
Date: Fri, 18 Oct 2024 12:32:49 +0200 (CEST)
From: Jiri Kosina <jikos@...nel.org>
To: Bartłomiej Maryńczak <marynczakbartlomiej@...il.com>
cc: Benjamin Tissoires <bentiss@...nel.org>, linux-input@...r.kernel.org, 
    linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: i2c-hid: Delayed i2c resume wakeup for Goodix
 touchpads

On Tue, 8 Oct 2024, Bartłomiej Maryńczak wrote:

> Patch for Goodix 27c6:0d42 touchpads found in Inspiron 5515 laptops.
> 
> After resume from suspend, one can communicate with this device just 
> fine. We can read data from it or request a reset, but for some reason 
> the interrupt line will not go up when new events are available. (it can 
> correctly respond to a reset with an interrupt tho)
> 
> The only way I found to wake this device up is to send anything to it 
> after ~1.5s mark, for example a simple read request, or power mode 
> change.
> 
> In this patch, I simply delay the resume steps with msleep, this will 
> cause the set_power request to happen after the ~1.5s barrier causing 
> the device to resume its event interrupts.
> 
> Sleep was used rather than delayed_work to make this workaround as 
> non-invasive as possible.

Alright, that's geniunely horrible :), but I guess the device is just 
broken, so let's just do this until / if someone is able to figure out a 
better workaround.

Queued in hid.git#for-6.12/upstream-fixes.

Thanks,

-- 
Jiri Kosina
SUSE Labs