linux-kernel - Re: [PATCH v2] kbuild: Restore the ability to build out of tree dtbs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNAR4h6NZ+D0BK+q4VQBeHWpjzRBQFQ9ovBrftM=6dHRcUg@mail.gmail.com>
Date: Fri, 18 Oct 2024 20:19:00 +0900
From: Masahiro Yamada <masahiroy@...nel.org>
To: Chris Packham <chris.packham@...iedtelesis.co.nz>
Cc: nathan@...nel.org, nicolas@...sle.eu, linux-kbuild@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] kbuild: Restore the ability to build out of tree dtbs

On Thu, Oct 17, 2024 at 4:59 AM Chris Packham
<chris.packham@...iedtelesis.co.nz> wrote:
>
> A build pattern to handle out of tree dtbs is to copy the .dts file into
> the kernel source tree and run `make myboard.dtb`. This is supported by
> the wildcard %.dtb rule in the Makefile but recent changes to split the
> dtb handling out of scripts/Makefile.build stopped this from working.
> Restore this functionality by looking for .dtb in $(MAKECMDGOALS) as
> well as $(targets).
>
> Fixes: e7e2941300d2 ("kbuild: split device tree build rules into scripts/Makefile.dtbs")
> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>
> ---

This is not a use-case in upstream.

If you drop-in your downstream DT to the kernel tree,
you need to associate it with Makefile.





>
> Notes:
>     Changes in v2:
>     - keep $(target) and search for .dtb in $(MAKECMDGOALS)
>
>  scripts/Makefile.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/Makefile.build b/scripts/Makefile.build
> index 8f423a1faf50..78763a4bc58a 100644
> --- a/scripts/Makefile.build
> +++ b/scripts/Makefile.build
> @@ -449,7 +449,7 @@ ifneq ($(userprogs),)
>  include $(srctree)/scripts/Makefile.userprogs
>  endif
>
> -ifneq ($(need-dtbslist)$(dtb-y)$(dtb-)$(filter %.dtb %.dtb.o %.dtbo.o,$(targets)),)
> +ifneq ($(need-dtbslist)$(dtb-y)$(dtb-)$(filter %.dtb %.dtb.o %.dtbo.o,$(targets))$(filter %.dtb,$(MAKECMDGOALS)),)
>  include $(srctree)/scripts/Makefile.dtbs
>  endif
>
> --
> 2.47.0
>
>


--
Best Regards
Masahiro Yamada