linux-kernel - Re: [PATCH net-next v2] tools: ynl-gen: use big-endian netlink attribute types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241018114646.GH1697@kernel.org>
Date: Fri, 18 Oct 2024 12:46:46 +0100
From: Simon Horman <horms@...nel.org>
To: Asbjørn Sloth Tønnesen <ast@...erby.net>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	David Ahern <dsahern@...nel.org>,
	Matthieu Baerts <matttbe@...nel.org>,
	Mat Martineau <martineau@...nel.org>,
	Geliang Tang <geliang@...nel.org>,
	Donald Hunter <donald.hunter@...il.com>, netdev@...r.kernel.org,
	mptcp@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2] tools: ynl-gen: use big-endian netlink
 attribute types

On Thu, Oct 17, 2024 at 09:47:02AM +0000, Asbjørn Sloth Tønnesen wrote:
> Change ynl-gen-c.py to use NLA_BE16 and NLA_BE32 types to represent
> big-endian u16 and u32 ynl types.
> 
> Doing this enables those attributes to have range checks applied, as
> the validator will then convert to host endianness prior to validation.
> 
> The autogenerated kernel/uapi code have been regenerated by running:
>   ./tools/net/ynl/ynl-regen.sh -f
> 
> This changes the policy types of the following attributes:
> 
>   FOU_ATTR_PORT (NLA_U16 -> NLA_BE16)
>   FOU_ATTR_PEER_PORT (NLA_U16 -> NLA_BE16)
>     These two are used with nla_get_be16/nla_put_be16().
> 
>   MPTCP_PM_ADDR_ATTR_ADDR4 (NLA_U32 -> NLA_BE32)
>     This one is used with nla_get_in_addr/nla_put_in_addr(),
>     which uses nla_get_be32/nla_put_be32().
> 
> IOWs the generated changes are AFAICT aligned with their implementations.
> 
> The generated userspace code remains identical, and have been verified
> by comparing the output generated by the following command:
>   make -C tools/net/ynl/generated
> 
> Signed-off-by: Asbjørn Sloth Tønnesen <ast@...erby.net>
> 
> ---
> Changelog:
> 
> v2:
> - Re-implement to avoid adding a new Type attribute (Requested by Jakub).
> 
> v1: https://lore.kernel.org/netdev/20240913085555.134788-1-ast@fiberby.net/

Thanks for addressing Jakub's review of v1.

Reviewed-by: Simon Horman <horms@...nel.org>