[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZxJVCb13lQ4h2KRD@smile.fi.intel.com>
Date: Fri, 18 Oct 2024 15:31:05 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Baojun Xu <baojun.xu@...com>
Cc: tiwai@...e.de, robh+dt@...nel.org, lgirdwood@...il.com, perex@...ex.cz,
pierre-louis.bossart@...ux.intel.com, shenghao-ding@...com,
navada@...com, 13916275206@....com, v-hampiholi@...com, v-po@...com,
linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org,
liam.r.girdwood@...el.com, yung-chuan.liao@...ux.intel.com,
broonie@...nel.org, antheas.dk@...il.com
Subject: Re: [PATCH v2] ALSA: hda/tas2781: Add speaker id check for ASUS
projects
On Fri, Oct 18, 2024 at 03:11:18PM +0800, Baojun Xu wrote:
> Add speaker id check by gpio in ACPI for ASUS projects.
> In other vendors, speaker id was checked by BIOS, and was applied in
> last bit of subsys id, so we can load corresponding firmware binary file
> for its speaker by subsys id.
> But in ASUS project, the firmware binary name will be appended an extra
> number to tell the speakers from different vendors. And this single digit
> come from gpio level of speaker id in BIOS.
...
> + sub = acpi_get_subsystem_id(ACPI_HANDLE(physdev));
> + if (IS_ERR(sub)) {
> + dev_err(p->dev, "Failed to get SUBSYS ID.\n");
> + goto err;
> + }
> + // Speaker id was needed for ASUS projects.
> + if (strstr(sub, TAS2781_ASUS_ID)) {
strstr() is wrong. You can get 1043 in the middle of the bigger number,
or even text.
> + ret = devm_acpi_dev_add_driver_gpios(p->dev,
> + tas2781_speaker_id_gpios);
> + if (ret) {
> + dev_err(p->dev, "Unable to add GPIO.\n");
> + goto err;
No need. If this fails, the below most likely fail as well.
> + }
> + p->speaker_id = devm_gpiod_get(p->dev, "speakerid", GPIOD_IN);
> + if (IS_ERR(p->speaker_id)) {
> + dev_err(p->dev, "Failed to get Speaker id.\n");
> + goto err;
> + }
> + } else {
> + p->speaker_id = NULL;
> + }
...
> + if (tas_priv->speaker_id != NULL) {
> + // Speaker id need to be checked for ASUS only.
> + spk_id = gpiod_get_value(tas_priv->speaker_id);
> + if (spk_id < 0 || spk_id > 1) {
When "> 1" is possible? Isn't it a dead code?
> + // Speaker id is not valid, use default.
> + dev_dbg(tas_priv->dev, "Wrong spk_id = %d\n", spk_id);
> + spk_id = 0;
> + }
> + scnprintf(tas_priv->coef_binaryname,
Why 'c' variant? You do not check the return value anyway. So, what's the point?
> + sizeof(tas_priv->coef_binaryname),
> + "TAS2XXX%04X%01d.bin",
> + lower_16_bits(codec->core.subsystem_id),
> + spk_id);
> + } else {
> + scnprintf(tas_priv->coef_binaryname,
Ditto.
> + sizeof(tas_priv->coef_binaryname),
> + "TAS2XXX%04X.bin",
> + lower_16_bits(codec->core.subsystem_id));
> + }
...
> @@ -793,7 +844,6 @@ static int tas2781_hda_i2c_probe(struct i2c_client *clt)
> const char *device_name;
> int ret;
>
> -
> tas_hda = devm_kzalloc(&clt->dev, sizeof(*tas_hda), GFP_KERNEL);
> if (!tas_hda)
> return -ENOMEM;
Stray change.
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists