linux-kernel - Re: [PATCH] i2c: designware: Add ACPI HID for DWAPB I2C controller on Fujitsu MONAKA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZxJXj3holsMIdnC2@smile.fi.intel.com>
Date: Fri, 18 Oct 2024 15:41:51 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Yoshihiro Furudera <fj5100bi@...itsu.com>
Cc: Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	Jan Dabros <jsd@...ihalf.com>, Andi Shyti <andi.shyti@...nel.org>,
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: designware: Add ACPI HID for DWAPB I2C controller
 on Fujitsu MONAKA

On Fri, Oct 18, 2024 at 01:58:26AM +0000, Yoshihiro Furudera wrote:
> This patch enables DWAPB I2C controller support on Fujitsu MONAKA.

s/This patch enables/Enable/

Also please give more details:
1) is this ID already present in the wild
   (in the products that one may just go and buy)?
if so, mention the example of the product.

2) provide an excerpt from DSDT for the Device object that uses this _HID.

Otherwise the vendor ID is legit [1] and code wise patch is okay.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

[1]: https://uefi.org/ACPI_ID_List?acpi_search=fuji

-- 
With Best Regards,
Andy Shevchenko