linux-kernel - Re: [PATCH 3/3] power: reset: nvmem-reboot-mode: fix write for small cells

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202410190829.e98plEvU-lkp@intel.com>
Date: Sat, 19 Oct 2024 08:26:26 +0800
From: kernel test robot <lkp@...el.com>
To: Jennifer Berringer <jberring@...hat.com>,
	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
	Sebastian Reichel <sre@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Maxime Ripard <mripard@...nel.org>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
	linux-pm@...r.kernel.org, Jennifer Berringer <jberring@...hat.com>
Subject: Re: [PATCH 3/3] power: reset: nvmem-reboot-mode: fix write for small
 cells

Hi Jennifer,

kernel test robot noticed the following build errors:

[auto build test ERROR on 98f7e32f20d28ec452afb208f9cffc08448a2652]

url:    https://github.com/intel-lab-lkp/linux/commits/Jennifer-Berringer/nvmem-core-add-nvmem_cell_write_variable_u32/20241018-001140
base:   98f7e32f20d28ec452afb208f9cffc08448a2652
patch link:    https://lore.kernel.org/r/20241017160904.2803663-3-jberring%40redhat.com
patch subject: [PATCH 3/3] power: reset: nvmem-reboot-mode: fix write for small cells
config: i386-randconfig-015-20241019 (https://download.01.org/0day-ci/archive/20241019/202410190829.e98plEvU-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241019/202410190829.e98plEvU-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410190829.e98plEvU-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/power/reset/nvmem-reboot-mode.c: In function 'nvmem_reboot_mode_write':
>> drivers/power/reset/nvmem-reboot-mode.c:27:15: error: implicit declaration of function 'nvmem_cell_write_variable_u32'; did you mean 'nvmem_cell_read_variable_le_u32'? [-Werror=implicit-function-declaration]
      27 |         ret = nvmem_cell_write_variable_u32(nvmem_rbm->cell, magic);
         |               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         |               nvmem_cell_read_variable_le_u32
   cc1: some warnings being treated as errors


vim +27 drivers/power/reset/nvmem-reboot-mode.c

    18	
    19	static int nvmem_reboot_mode_write(struct reboot_mode_driver *reboot,
    20					    unsigned int magic)
    21	{
    22		int ret;
    23		struct nvmem_reboot_mode *nvmem_rbm;
    24	
    25		nvmem_rbm = container_of(reboot, struct nvmem_reboot_mode, reboot);
    26	
  > 27		ret = nvmem_cell_write_variable_u32(nvmem_rbm->cell, magic);
    28		if (ret < 0)
    29			dev_err(reboot->dev, "update reboot mode bits failed\n");
    30	
    31		return ret;
    32	}
    33	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki