linux-kernel - RE: [PATCH v2 09/10] x86/mce/amd: Remove unnecessary NULL pointer initializations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CY8PR11MB713462FCF6A2B75C785C39F089412@CY8PR11MB7134.namprd11.prod.outlook.com>
Date: Sat, 19 Oct 2024 07:40:03 +0000
From: "Zhuo, Qiuxu" <qiuxu.zhuo@...el.com>
To: "Mehta, Sohil" <sohil.mehta@...el.com>, "Luck, Tony"
	<tony.luck@...el.com>, "bp@...en8.de" <bp@...en8.de>
CC: "tglx@...utronix.de" <tglx@...utronix.de>, "dave.hansen@...ux.intel.com"
	<dave.hansen@...ux.intel.com>, "mingo@...hat.com" <mingo@...hat.com>,
	"hpa@...or.com" <hpa@...or.com>, "x86@...nel.org" <x86@...nel.org>,
	"linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 09/10] x86/mce/amd: Remove unnecessary NULL pointer
 initializations

> From: Mehta, Sohil <sohil.mehta@...el.com>
> [...]
> Subject: Re: [PATCH v2 09/10] x86/mce/amd: Remove unnecessary NULL
> pointer initializations
> 
> On 10/16/2024 5:30 AM, Qiuxu Zhuo wrote:
> > As the variables {pos, tmp, block, first_block} are all initialized
> 
> This level of detail is generally not needed in the commit message. I would
> rather just skip the {} brackets altogether.

OK. I'll take your suggestion into account in the next version.

-Qiuxu