linux-kernel - Re: [PATCH v5 7/8] iio: adc: ad7606: Add iio-backend support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202410190802.CLaySBOq-lkp@intel.com>
Date: Sat, 19 Oct 2024 08:36:40 +0800
From: kernel test robot <lkp@...el.com>
To: Guillaume Stols <gstols@...libre.com>,
	Uwe Kleine-König <ukleinek@...nel.org>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Michael Hennerich <Michael.Hennerich@...log.com>,
	Jonathan Cameron <jic23@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Jonathan Corbet <corbet@....net>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	linux-pwm@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-fbdev@...r.kernel.org, linux-iio@...r.kernel.org,
	devicetree@...r.kernel.org, linux-doc@...r.kernel.org,
	aardelean@...libre.com, dlechner@...libre.com,
	jstephan@...libre.com, nuno.sa@...log.com,
	Guillaume Stols <gstols@...libre.com>
Subject: Re: [PATCH v5 7/8] iio: adc: ad7606: Add iio-backend support

Hi Guillaume,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 465644ac29536d10178b5ca4684d0b84765b9fa4]

url:    https://github.com/intel-lab-lkp/linux/commits/Guillaume-Stols/dt-bindings-iio-adc-ad7606-Remove-spi-cpha-from-required/20241015-215831
base:   465644ac29536d10178b5ca4684d0b84765b9fa4
patch link:    https://lore.kernel.org/r/20241015-ad7606_add_iio_backend_support-v5-7-654faf1ae08c%40baylibre.com
patch subject: [PATCH v5 7/8] iio: adc: ad7606: Add iio-backend support
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20241019/202410190802.CLaySBOq-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241019/202410190802.CLaySBOq-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410190802.CLaySBOq-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/iio/adc/ad7606_par.c:173:22: warning: unused variable 'back' [-Wunused-variable]
     173 |         struct iio_backend *back;
         |                             ^~~~
   1 warning generated.


vim +/back +173 drivers/iio/adc/ad7606_par.c

   164	
   165	static int ad7606_par_probe(struct platform_device *pdev)
   166	{
   167		const struct ad7606_chip_info *chip_info;
   168		const struct platform_device_id *id;
   169		struct resource *res;
   170		void __iomem *addr;
   171		resource_size_t remap_size;
   172		int irq;
 > 173		struct iio_backend *back;
   174	
   175		/*
   176		 * If a firmware node is available (ACPI or DT), platform_device_id is null
   177		 * and we must use get_match_data.
   178		 */
   179		if (dev_fwnode(&pdev->dev)) {
   180			chip_info = device_get_match_data(&pdev->dev);
   181			if (device_property_present(&pdev->dev, "io-backends"))
   182				/*
   183				 * If a backend is available ,call the core probe with backend
   184				 * bops, otherwise use the former bops.
   185				 */
   186				return ad7606_probe(&pdev->dev, 0, NULL,
   187						    chip_info,
   188						    &ad7606_bi_bops);
   189		} else {
   190			id = platform_get_device_id(pdev);
   191			chip_info = (const struct ad7606_chip_info *)id->driver_data;
   192		}
   193	
   194		irq = platform_get_irq(pdev, 0);
   195		if (irq < 0)
   196			return irq;
   197	
   198		addr = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
   199		if (IS_ERR(addr))
   200			return PTR_ERR(addr);
   201	
   202		remap_size = resource_size(res);
   203	
   204		return ad7606_probe(&pdev->dev, irq, addr, chip_info,
   205				    remap_size > 1 ? &ad7606_par16_bops :
   206				    &ad7606_par8_bops);
   207	}
   208	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki