linux-kernel - Re: [PATCH] iio: dac: ad8460: add SPI device match table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241019122629.268197e8@jic23-huawei>
Date: Sat, 19 Oct 2024 12:26:29 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: David Lechner <dlechner@...libre.com>
Cc: Mariel Tinaco <Mariel.Tinaco@...log.com>, Michael Hennerich
 <Michael.Hennerich@...log.com>, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: dac: ad8460: add SPI device match table

On Fri, 18 Oct 2024 16:44:48 -0500
David Lechner <dlechner@...libre.com> wrote:

> Add SPI device match table for ADI AD8460 DAC. As described in [1], this
> is required for the module to automatically load, even when using DT.
> 
> [1]: https://lore.kernel.org/all/20210921192149.50740-1-broonie@kernel.org/
> 
> Signed-off-by: David Lechner <dlechner@...libre.com>
One day I'll remember to check for this when reviewing.

This is actually another corner case and fine for now.
In the link you reference check the driver name matching just
before the warning print.

That works if there is only one ID. Still better to clean
this up as a form of hardening against future problems.

Applied.

Jonathan

> ---
>  drivers/iio/dac/ad8460.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/iio/dac/ad8460.c b/drivers/iio/dac/ad8460.c
> index dc8c76ba573d..ded442d4060d 100644
> --- a/drivers/iio/dac/ad8460.c
> +++ b/drivers/iio/dac/ad8460.c
> @@ -929,12 +929,19 @@ static const struct of_device_id ad8460_of_match[] = {
>  };
>  MODULE_DEVICE_TABLE(of, ad8460_of_match);
>  
> +static const struct spi_device_id ad8460_spi_match[] = {
> +	{ .name = "ad8460" },
> +	{ }
> +};
> +MODULE_DEVICE_TABLE(spi, ad8460_spi_match);
> +
>  static struct spi_driver ad8460_driver = {
>  	.driver = {
>  		.name = "ad8460",
>  		.of_match_table = ad8460_of_match,
>  	},
>  	.probe = ad8460_probe,
> +	.id_table = ad8460_spi_match,
>  };
>  module_spi_driver(ad8460_driver);
>  
> 
> ---
> base-commit: f2493655d2d3d5c6958ed996b043c821c23ae8d3
> change-id: 20241018-iio-dac-ad8460-add-spi-match-table-906dd36cb033
> 
> Best regards,