linux-kernel - Re: [PATCH RFC 14/14] arm64: dts: qcom: Add Xiaomi Redmi 5A

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d55a8f5d7f9b371fd2b51ec079adbf8d@mainlining.org>
Date: Sat, 19 Oct 2024 16:40:34 +0200
From: barnabas.czeman@...nlining.org
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc: Bjorn Andersson <andersson@...nel.org>, Linus Walleij
 <linus.walleij@...aro.org>, Rob Herring <robh@...nel.org>, Krzysztof
 Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Konrad
 Dybcio <konradybcio@...nel.org>, Lee Jones <lee@...nel.org>, Amit Kucheria
 <amitk@...nel.org>, Thara Gopinath <thara.gopinath@...il.com>, "Rafael J.
 Wysocki" <rafael@...nel.org>, Daniel Lezcano <daniel.lezcano@...aro.org>,
 Zhang Rui <rui.zhang@...el.com>, Lukasz Luba <lukasz.luba@....com>, Joerg
 Roedel <joro@...tes.org>, Will Deacon <will@...nel.org>, Robin Murphy
 <robin.murphy@....com>, Srinivas Kandagatla
 <srinivas.kandagatla@...aro.org>, linux-arm-msm@...r.kernel.org,
 linux-gpio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
 iommu@...ts.linux.dev
Subject: Re: [PATCH RFC 14/14] arm64: dts: qcom: Add Xiaomi Redmi 5A

On 2024-10-19 16:38, Dmitry Baryshkov wrote:
> On Sat, Oct 19, 2024 at 03:57:54PM +0200, 
> barnabas.czeman@...nlining.org wrote:
>> On 2024-10-19 15:48, Dmitry Baryshkov wrote:
>> > On Sat, Oct 19, 2024 at 01:50:51PM +0200, Barnabás Czémán wrote:
>> > > Add initial support for Xiaomi Redmi 5A (riva).
>> > >
>> > > Signed-off-by: Barnabás Czémán <barnabas.czeman@...nlining.org>
>> > > ---
>> > >  arch/arm64/boot/dts/qcom/Makefile                |   1 +
>> > >  arch/arm64/boot/dts/qcom/msm8917-xiaomi-riva.dts | 295
>> > > +++++++++++++++++++++++
>> > >  2 files changed, 296 insertions(+)
>> > >
>> > > diff --git a/arch/arm64/boot/dts/qcom/Makefile
>> > > b/arch/arm64/boot/dts/qcom/Makefile
>> > > index 065bb19481c16db2affd291826d420c83a89c52a..79add0e07d8a5f3362d70b0aaaaa9b8c48e31239
>> > > 100644
>> > > --- a/arch/arm64/boot/dts/qcom/Makefile
>> > > +++ b/arch/arm64/boot/dts/qcom/Makefile
>> > > @@ -59,6 +59,7 @@ dtb-$(CONFIG_ARCH_QCOM)	+=
>> > > msm8916-wingtech-wt86518.dtb
>> > >  dtb-$(CONFIG_ARCH_QCOM)	+= msm8916-wingtech-wt86528.dtb
>> > >  dtb-$(CONFIG_ARCH_QCOM)	+= msm8916-wingtech-wt88047.dtb
>> > >  dtb-$(CONFIG_ARCH_QCOM)	+= msm8916-yiming-uz801v3.dtb
>> > > +dtb-$(CONFIG_ARCH_QCOM)	+= msm8917-xiaomi-riva.dtb
>> > >  dtb-$(CONFIG_ARCH_QCOM)	+= msm8929-wingtech-wt82918hd.dtb
>> > >  dtb-$(CONFIG_ARCH_QCOM)	+= msm8939-huawei-kiwi.dtb
>> > >  dtb-$(CONFIG_ARCH_QCOM)	+= msm8939-longcheer-l9100.dtb
>> > > diff --git a/arch/arm64/boot/dts/qcom/msm8917-xiaomi-riva.dts
>> > > b/arch/arm64/boot/dts/qcom/msm8917-xiaomi-riva.dts
>> > > new file mode 100644
>> > > index 0000000000000000000000000000000000000000..7553f73603fc87797b0d424a2af6f2da65c90f5f
>> > > --- /dev/null
>> > > +++ b/arch/arm64/boot/dts/qcom/msm8917-xiaomi-riva.dts
>> > > @@ -0,0 +1,295 @@
>> > > +// SPDX-License-Identifier: BSD-3-Clause
>> > > +/*
>> > > + * Copyright (c) 2023, Barnabas Czeman
>> > > + */
>> > > +
>> > > +/dts-v1/;
>> > > +
>> > > +#include <dt-bindings/arm/qcom,ids.h>
>> > > +#include <dt-bindings/gpio/gpio.h>
>> > > +#include <dt-bindings/input/linux-event-codes.h>
>> > > +#include <dt-bindings/leds/common.h>
>> > > +#include "msm8917.dtsi"
>> > > +#include "pm8937.dtsi"
>> > > +
>> > > +/ {
>> > > +	model = "Xiaomi Redmi 5A (riva)";
>> > > +	compatible = "xiaomi,riva", "qcom,msm8917";
>> > > +	chassis-type = "handset";
>> > > +
>> > > +	qcom,msm-id = <QCOM_ID_MSM8917 0>;
>> > > +	qcom,board-id = <0x1000b 2>, <0x2000b 2>;
>> >
>> > Is this required to boot?
>> Yes
> 
> Hmm, did you verify the dts against DT bindings? I think you need to 
> fix
> them.
I have checked with this `make CHECK_DTBS=1 
qcom/msm8917-xiaomi-riva.dtb`