linux-kernel - Re: [PATCH 1/2] bindings: ipmi: Add alert GPIO enhancement for SSIF BMC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <172935492333.3562529.4909443000024833728.robh@kernel.org>
Date: Sat, 19 Oct 2024 11:22:03 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Potin Lai <potin.lai.pt@...il.com>
Cc: Potin Lai <potin.lai@...ntatw.com>, 
 Quan Nguyen <quan@...amperecomputing.com>, devicetree@...r.kernel.org, 
 Cosmo Chou <cosmo.chou@...ntatw.com>, Corey Minyard <minyard@....org>, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, 
 Conor Dooley <conor+dt@...nel.org>, 
 openipmi-developer@...ts.sourceforge.net, linux-kernel@...r.kernel.org, 
 Patrick Williams <patrick@...cx.xyz>
Subject: Re: [PATCH 1/2] bindings: ipmi: Add alert GPIO enhancement for
 SSIF BMC driver

On Sat, 19 Oct 2024 23:38:04 +0800, Potin Lai wrote:
> Introduce the `alert-gpios` property to define an alert pin, enabling
> the BMC to notify the host when a response is available.
> 
> Signed-off-by: Potin Lai <potin.lai.pt@...il.com>
> ---
>  Documentation/devicetree/bindings/ipmi/ssif-bmc.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Error: Documentation/devicetree/bindings/ipmi/ssif-bmc.example.dts:25.40-41 syntax error
FATAL ERROR: Unable to parse input tree
make[2]: *** [scripts/Makefile.dtbs:129: Documentation/devicetree/bindings/ipmi/ssif-bmc.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1442: dt_binding_check] Error 2
make: *** [Makefile:224: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241019-ssif-alert-gpios-v1-1-483eee5f99d3@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.