linux-kernel - Re: [PATCH] mtd: ubi: fix unreleased fwnode_handle in find_volume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <40e3ba82-6697-4ed5-a593-c54c6dcd2421@gmail.com>
Date: Sat, 19 Oct 2024 22:32:49 +0200
From: Javier Carrasco <javier.carrasco.cruz@...il.com>
To: Richard Weinberger <richard@....at>,
 Zhihao Cheng <chengzhihao1@...wei.com>,
 Miquel Raynal <miquel.raynal@...tlin.com>,
 Vignesh Raghavendra <vigneshr@...com>, Daniel Golle <daniel@...rotopia.org>
Cc: linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mtd: ubi: fix unreleased fwnode_handle in
 find_volume_fwnode()

On 19/10/2024 22:27, Javier Carrasco wrote:
> The 'fw_vols' fwnode_handle initialized via
> device_get_named_child_node() requires explicit calls to
> fwnode_handle_put() when the variable is no longer required.
> 
> Add the missing calls to fwnode_handle_put() before the function
> returns.
> 
> Fixes: 51932f9fc487 ("mtd: ubi: populate ubi volume fwnode")
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@...il.com>
> ---
>  drivers/mtd/ubi/vmt.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/mtd/ubi/vmt.c b/drivers/mtd/ubi/vmt.c
> index 5a3558bbb903..e5cf3bdca3b0 100644
> --- a/drivers/mtd/ubi/vmt.c
> +++ b/drivers/mtd/ubi/vmt.c
> @@ -143,8 +143,10 @@ static struct fwnode_handle *find_volume_fwnode(struct ubi_volume *vol)
>  		    vol->vol_id != volid)
>  			continue;
>  
> +		fwnode_handle_put(fw_vols);
>  		return fw_vol;
>  	}
> +	fwnode_handle_put(fw_vols);
>  
>  	return NULL;
>  }
> 
> ---
> base-commit: f2493655d2d3d5c6958ed996b043c821c23ae8d3
> change-id: 20241019-mtd-uvi-fwnode_handle_put-7b220d2778b5
> 
> Best regards,

I just saw that the bug was introduced in late Dec. 2023, so maybe a

Cc: stable@...r.kernel.org

will be necessary in this case, right?

Best regards,
Javier Carrasco