[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ZxL5qQGXDrcdEtnR@google.com>
Date: Fri, 18 Oct 2024 17:13:29 -0700
From: Dmitry Torokhov <dmitry.torokhov@...il.com>
To: Nikita Travkin <nikita@...n.ru>
Cc: Linus Walleij <linus.walleij@...aro.org>, linux-input@...r.kernel.org,
linux-kernel@...r.kernel.org, Jakob Hauser <jahau@...ketmail.com>
Subject: Re: [PATCH v2] Input: zinitix - Don't fail if linux,keycodes prop is
absent
On Fri, Oct 04, 2024 at 09:17:30PM +0500, Nikita Travkin wrote:
> When initially adding the touchkey support, a mistake was made in the
> property parsing code. The possible negative errno from
> device_property_count_u32() was never checked, which was an oversight
> left from converting to it from the of_property as part of the review
> fixes.
>
> Re-add the correct handling of the absent property, in which case zero
> touchkeys should be assumed, which would disable the feature.
>
> Reported-by: Jakob Hauser <jahau@...ketmail.com>
> Tested-by: Jakob Hauser <jahau@...ketmail.com>
> Fixes: 075d9b22c8fe ("Input: zinitix - add touchkey support")
> Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
> Signed-off-by: Nikita Travkin <nikita@...n.ru>
Applied, thank you.
--
Dmitry
Powered by blists - more mailing lists