linux-kernel - Re: [PATCH 0/2] Using i2c-hid-of-elan driver instead of i2c-hid-of driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAC=S1njH=D247j80MezGPHjwg_ZLWtH5gasXfOB-Y9Geq50frA@mail.gmail.com>
Date: Sat, 19 Oct 2024 13:35:47 +0800
From: Fei Shao <fshao@...omium.org>
To: "Rob Herring (Arm)" <robh@...nel.org>, Hsin-Te Yuan <yuanhsinte@...omium.org>
Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, devicetree@...r.kernel.org, 
	Hsin-Yi Wang <hsinyi@...omium.org>, Benjamin Tissoires <bentiss@...nel.org>, linux-kernel@...r.kernel.org, 
	Conor Dooley <conor+dt@...nel.org>, Enric Balletbo i Serra <eballetbo@...nel.org>, 
	Matthias Brugger <matthias.bgg@...il.com>, linux-mediatek@...ts.infradead.org, 
	linux-arm-kernel@...ts.infradead.org, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Hans de Goede <hdegoede@...hat.com>
Subject: Re: [PATCH 0/2] Using i2c-hid-of-elan driver instead of i2c-hid-of driver

On Fri, Oct 18, 2024 at 8:57 PM Rob Herring (Arm) <robh@...nel.org> wrote:
>
>
> On Fri, 18 Oct 2024 12:03:03 +0000, Hsin-Te Yuan wrote:
> > After commit 2be404486c05 ("HID: i2c-hid-of: Add reset GPIO support to
> > i2c-hid-of"), i2c-hid-of driver resets the touchscreen without having
> > proper post-reset delay on OF platform.  From the commit message of that
> > commit, not to decribe poset-reset delay in device tree is intended.
> > Instead, describing the delay in platform data and changing to use
> > specialized driver is more preferable solution.
> >
> > Also workaround the race condition of pinctrl used by touchscreen and
> > trackpad in this series to avoid merge conflict.
> >
> > Signed-off-by: Hsin-Te Yuan <yuanhsinte@...omium.org>
> > ---
> > Hsin-Te Yuan (2):
> >       arm64: dts: mediatek: mt8183: Fix race condition of pinctrl
> >       arm64: dts: mediatek: mt8183: Switch to Elan touchscreen driver
> >
> >  arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dts |  2 --
> >  arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cozmo.dts  |  3 ---
> >  arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dts   | 12 +++---------
> >  .../boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dts   | 11 ++---------
> >  .../boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dts   | 11 ++---------
> >  .../boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dts   | 11 ++---------
> >  .../arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-fennel.dtsi |  3 ---
> >  .../boot/dts/mediatek/mt8183-kukui-jacuzzi-juniper.dtsi      |  3 ---
> >  arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico.dts   |  3 ---
> >  arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico6.dts  |  3 ---
> >  .../arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-willow.dtsi |  3 ---
> >  arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi       | 10 +++-------
> >  12 files changed, 12 insertions(+), 63 deletions(-)
> > ---
> > base-commit: eca631b8fe808748d7585059c4307005ca5c5820
> > change-id: 20241018-post-reset-ac66b0351613
> >
> > Best regards,
> > --
> > Hsin-Te Yuan <yuanhsinte@...omium.org>
> >
> >
> >
>
>
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
>
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to reply
> unless the platform maintainer has comments.
>
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
>
>   pip3 install dtschema --upgrade
>
>
> New warnings running 'make CHECK_DTBS=y mediatek/mt8183-kukui-jacuzzi-burnet.dtb mediatek/mt8183-kukui-jacuzzi-cozmo.dtb mediatek/mt8183-kukui-jacuzzi-damu.dtb mediatek/mt8183-kukui-jacuzzi-fennel-sku1.dtb mediatek/mt8183-kukui-jacuzzi-fennel-sku6.dtb mediatek/mt8183-kukui-jacuzzi-fennel-sku7.dtb mediatek/mt8183-kukui-jacuzzi-pico.dtb mediatek/mt8183-kukui-jacuzzi-pico6.dtb' for 20241018-post-reset-v1-0-5aadb7550037@...omium.org:
>
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico.dtb: dpi@...15000: power-domains: False schema does not allow [[92, 7]]
>         from schema $id: http://devicetree.org/schemas/display/mediatek/mediatek,dpi.yaml#
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-damu.dtb: dpi@...15000: power-domains: False schema does not allow [[94, 7]]
>         from schema $id: http://devicetree.org/schemas/display/mediatek/mediatek,dpi.yaml#
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-cozmo.dtb: dpi@...15000: power-domains: False schema does not allow [[92, 7]]
>         from schema $id: http://devicetree.org/schemas/display/mediatek/mediatek,dpi.yaml#
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico6.dtb: dpi@...15000: power-domains: False schema does not allow [[90, 7]]
>         from schema $id: http://devicetree.org/schemas/display/mediatek/mediatek,dpi.yaml#
> arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dtb: dpi@...15000: power-domains: False schema does not allow [[92, 7]]
>         from schema $id: http://devicetree.org/schemas/display/mediatek/mediatek,dpi.yaml#
>

I sent a patch that should fix these errors:
https://lore.kernel.org/all/20241019052935.553886-1-fshao@chromium.org/

Regards,
Fei