linux-kernel - [gustavoars:testing/wfamnae-next20241015-2 1/20] kernel/sched/ext.c:3454:10: error: incompatible pointer types returning 'struct cgroup_hdr *' from a function with result type 'struct cgroup *'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202410201911.RjSrvRuo-lkp@intel.com>
Date: Sun, 20 Oct 2024 19:15:19 +0800
From: kernel test robot <lkp@...el.com>
To: "Gustavo A. R. Silva" <gustavoars@...nel.org>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	"Gustavo A. R. Silva" <gustavo@...eddedor.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: [gustavoars:testing/wfamnae-next20241015-2 1/20]
 kernel/sched/ext.c:3454:10: error: incompatible pointer types returning
 'struct cgroup_hdr *' from a function with result type 'struct cgroup *'

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git testing/wfamnae-next20241015-2
head:   f4f8ca5cd7f039bcab816194342c7b6101e891fe
commit: 7c9abd83f6b3412752cbb1a76954568b5316ad61 [1/20] cgroup: Avoid -Wflex-array-member-not-at-end warnings
config: i386-buildonly-randconfig-003-20241020 (https://download.01.org/0day-ci/archive/20241020/202410201911.RjSrvRuo-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241020/202410201911.RjSrvRuo-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410201911.RjSrvRuo-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from kernel/sched/build_policy.c:63:
>> kernel/sched/ext.c:3454:10: error: incompatible pointer types returning 'struct cgroup_hdr *' from a function with result type 'struct cgroup *' [-Werror,-Wincompatible-pointer-types]
    3454 |                 return &cgrp_dfl_root.cgrp;
         |                        ^~~~~~~~~~~~~~~~~~~
>> kernel/sched/ext.c:7152:17: error: incompatible pointer types initializing 'struct cgroup *' with an expression of type 'struct cgroup_hdr *' [-Werror,-Wincompatible-pointer-types]
    7152 |         struct cgroup *cgrp = &cgrp_dfl_root.cgrp;
         |                        ^      ~~~~~~~~~~~~~~~~~~~
   2 errors generated.


vim +3454 kernel/sched/ext.c

f0e1a0643a59bf Tejun Heo 2024-06-18  3442  
8195136669661f Tejun Heo 2024-09-04  3443  #ifdef CONFIG_EXT_GROUP_SCHED
8195136669661f Tejun Heo 2024-09-04  3444  static struct cgroup *tg_cgrp(struct task_group *tg)
8195136669661f Tejun Heo 2024-09-04  3445  {
8195136669661f Tejun Heo 2024-09-04  3446  	/*
8195136669661f Tejun Heo 2024-09-04  3447  	 * If CGROUP_SCHED is disabled, @tg is NULL. If @tg is an autogroup,
8195136669661f Tejun Heo 2024-09-04  3448  	 * @tg->css.cgroup is NULL. In both cases, @tg can be treated as the
8195136669661f Tejun Heo 2024-09-04  3449  	 * root cgroup.
8195136669661f Tejun Heo 2024-09-04  3450  	 */
8195136669661f Tejun Heo 2024-09-04  3451  	if (tg && tg->css.cgroup)
8195136669661f Tejun Heo 2024-09-04  3452  		return tg->css.cgroup;
8195136669661f Tejun Heo 2024-09-04  3453  	else
8195136669661f Tejun Heo 2024-09-04 @3454  		return &cgrp_dfl_root.cgrp;
8195136669661f Tejun Heo 2024-09-04  3455  }
8195136669661f Tejun Heo 2024-09-04  3456  

:::::: The code at line 3454 was first introduced by commit
:::::: 8195136669661fdfe54e9a8923c33b31c92fc1da sched_ext: Add cgroup support

:::::: TO: Tejun Heo <tj@...nel.org>
:::::: CC: Tejun Heo <tj@...nel.org>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki