linux-kernel - Re: [syzbot] [xfs?] KASAN: null-ptr-deref Write in xfs_filestream_select

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tencent_1756D762F77466DD937EA36E2960A3AD4405@qq.com>
Date: Sun, 20 Oct 2024 10:53:05 +0800
From: Edward Adam Davis <eadavis@...com>
To: syzbot+4125a3c514e3436a02e6@...kaller.appspotmail.com
Cc: linux-kernel@...r.kernel.org,
	syzkaller-bugs@...glegroups.com
Subject: Re: [syzbot] [xfs?] KASAN: null-ptr-deref Write in xfs_filestream_select_ag (2)

catch can't pick any perpag

#syz test

diff --git a/fs/xfs/xfs_filestream.c b/fs/xfs/xfs_filestream.c
index e3aaa0555597..8c8f341cf627 100644
--- a/fs/xfs/xfs_filestream.c
+++ b/fs/xfs/xfs_filestream.c
@@ -165,6 +165,7 @@ xfs_filestream_pick_ag(
 
 	trace_xfs_filestream_pick(pag, pino, free);
 	args->pag = pag;
+	printk("pag: %p, %s\n", args->pag, __func__);
 	return 0;
 
 }
@@ -298,8 +299,8 @@ xfs_filestream_create_association(
 
 	*longest = ap->length;
 	error = xfs_filestream_pick_ag(args, pino, agno, flags, longest);
-	if (error)
-		return error;
+	if (error || !args->pag)
+		return error ?: 0;
 
 	/*
 	 * We are going to use this perag now, so create an assoication for it.