linux-kernel - Re: [PATCH v7 3/3] drivers: iio: adc: add support for ad777x family

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241020142224.27bfdc04@jic23-huawei>
Date: Sun, 20 Oct 2024 14:22:24 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Ramona Alexandra Nechita <ramona.nechita@...log.com>
Cc: Lars-Peter Clausen <lars@...afoo.de>, Cosmin Tanislav
 <cosmin.tanislav@...log.com>, Michael Hennerich
 <Michael.Hennerich@...log.com>, Alexandru Ardelean
 <alexandru.ardelean@...log.com>, Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Nuno Sa
 <nuno.sa@...log.com>, David Lechner <dlechner@...libre.com>, George Mois
 <george.mois@...log.com>, Ana-Maria Cusco <ana-maria.cusco@...log.com>,
 <linux-iio@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <devicetree@...r.kernel.org>
Subject: Re: [PATCH v7 3/3] drivers: iio: adc: add support for ad777x family

On Sun, 20 Oct 2024 12:56:12 +0100
Jonathan Cameron <jic23@...nel.org> wrote:

> On Mon, 14 Oct 2024 17:32:00 +0300
> Ramona Alexandra Nechita <ramona.nechita@...log.com> wrote:
> 
> > Add support for AD7770, AD7771, AD7779 ADCs. The device is capable of
> > sending out data both on DOUT lines interface,as on the SDO line.
> > The driver currently implements only the SDO data streaming mode. SPI
> > communication is used alternatively for accessing registers and streaming
> > data. Register accesses are protected by crc8.
> > 
> > Signed-off-by: Ramona Alexandra Nechita <ramona.nechita@...log.com>  
> 
> A few comments inline.  I also tweaked white space in a few places
> whilst applying.  Target in IIO is still sub 80 chars whenever it
> doesn't hurt readability.
> 
> Also, you had unusual formatting for some of the macros. Avoid mixing
> tabs then spaces for indentation of the \ 
> 
> series applied to the togreg branch of iio.git and initially pushed
> out as testing so 0-day can take a look.
> 
> One missing return in the debugfs register access as well. Please
> check I fixed that up correctly.
Seems I missed the cancel button when I noticed the build message
just as the other email went out.  Sorry for the noise!

> 
> Thanks,
> 
> Jonathan