linux-kernel - Re: [PATCH net-next] net: dsa: mv88e6xxx: fix unreleased fwnode_handle in setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdY9jaXDoFzCC0ejLZPbbJ+QAgsb+QE29sDEw0Htgej1HQ@mail.gmail.com>
Date: Sun, 20 Oct 2024 19:16:31 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Javier Carrasco <javier.carrasco.cruz@...il.com>
Cc: Andrew Lunn <andrew@...n.ch>, Florian Fainelli <f.fainelli@...il.com>, 
	Vladimir Oltean <olteanv@...il.com>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: dsa: mv88e6xxx: fix unreleased
 fwnode_handle in setup_port()

On Sat, Oct 19, 2024 at 10:16 PM Javier Carrasco
<javier.carrasco.cruz@...il.com> wrote:

> 'ports_fwnode' is initialized via device_get_named_child_node(), which
> requires a call to fwnode_handle_put() when the variable is no longer
> required to avoid leaking memory.
>
> Add the missing fwnode_handle_put() after 'ports_fwnode' has been used
> and is no longer required.
>
> Fixes: 94a2a84f5e9e ("net: dsa: mv88e6xxx: Support LED control")
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@...il.com>

I was as puzzled as Andrew but I buy the explanation.
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij