linux-kernel - Re: [PATCH] platform/x86: asus-wmi: Support setting AIPT modes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c5aee6fc77427daca6e009cd22c3637bffec0219.camel@linux.intel.com>
Date: Sun, 20 Oct 2024 12:27:04 -0700
From: srinivas pandruvada <srinivas.pandruvada@...ux.intel.com>
To: Armin Wolf <W_Armin@....de>, corentin.chary@...il.com, luke@...nes.dev, 
	hdegoede@...hat.com, ilpo.jarvinen@...ux.intel.com
Cc: platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org, 
 Michael Larabel <Michael@...ronix.com>, Casey Bowman
 <casey.g.bowman@...el.com>
Subject: Re: [PATCH] platform/x86: asus-wmi: Support setting AIPT modes

> > 

[...]

> > +	adev = acpi_dev_get_first_match_dev("PNP0C14", "ATK", -1);
> 
> Is there really no way of changing the AIPT mode through the WMI
> interface?
> I would prefer using the WMI interface if available, since the
> firmware might
> assume that FANL is only called through the WMI interface.
> 
I wish the same. Didn't find any. Asus is aware of this change which I
submitted, they didn't suggest that there is alternative. 

> Do you have a acpidump from a affected device?
> 
Will send you.

Thanks,
Srinivas

> Thanks,
> Armin Wolf
> 
> > +	if (adev) {
> > +		acpi_handle handle = acpi_device_handle(adev);
> > +
> > +		acpi_dev_put(adev);
> > +
> > +		if (!acpi_has_method(handle, "FANL"))
> > +			return 0;
> > +
> > +		asus->acpi_mgmt_handle = handle;
> > +		asus->asus_aipt_present = true;
> > +		dev_info(dev, "ASUS Intelligent Performance
> > Technology (AIPT) is present\n");
> > +		/*
> > +		 * Set the mode corresponding to default Linux
> > platform power
> > +		 * profile Balanced
> > +		 */
> > +		asus_wmi_write_aipt_mode(asus, AIPT_STANDARD);
> > +	}
> > +
> >   	return 0;
> >   }
> >