linux-kernel - Re: [PATCH] platform/x86: asus-wmi: Support setting AIPT modes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eee71aa0-d0db-48a7-ade9-4b444c087de5@gmx.de>
Date: Sun, 20 Oct 2024 21:54:56 +0200
From: Armin Wolf <W_Armin@....de>
To: srinivas pandruvada <srinivas.pandruvada@...ux.intel.com>,
 corentin.chary@...il.com, luke@...nes.dev, hdegoede@...hat.com,
 ilpo.jarvinen@...ux.intel.com
Cc: platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
 Michael Larabel <Michael@...ronix.com>,
 Casey Bowman <casey.g.bowman@...el.com>
Subject: Re: [PATCH] platform/x86: asus-wmi: Support setting AIPT modes

Am 20.10.24 um 21:27 schrieb srinivas pandruvada:

> [...]
>
>>> +	adev = acpi_dev_get_first_match_dev("PNP0C14", "ATK", -1);
>> Is there really no way of changing the AIPT mode through the WMI
>> interface?
>> I would prefer using the WMI interface if available, since the
>> firmware might
>> assume that FANL is only called through the WMI interface.
>>
> I wish the same. Didn't find any. Asus is aware of this change which I
> submitted, they didn't suggest that there is alternative.
>
>> Do you have a acpidump from a affected device?
>>
> Will send you.
>
> Thanks,
> Srinivas

Thanks,

the return value of DSTS() on your device contains:

- 8-bit current AIPT mode
- 8-bit nothing
- 8-bit constant 0x07
- 8-bit constant 0x0a

Maybe you can try to find out more about the unknown constants. For the rest, you can use
the helper functions provided by the driver.

Thanks,
Armin Wolf

>> Thanks,
>> Armin Wolf
>>
>>> +	if (adev) {
>>> +		acpi_handle handle = acpi_device_handle(adev);
>>> +
>>> +		acpi_dev_put(adev);
>>> +
>>> +		if (!acpi_has_method(handle, "FANL"))
>>> +			return 0;
>>> +
>>> +		asus->acpi_mgmt_handle = handle;
>>> +		asus->asus_aipt_present = true;
>>> +		dev_info(dev, "ASUS Intelligent Performance
>>> Technology (AIPT) is present\n");
>>> +		/*
>>> +		 * Set the mode corresponding to default Linux
>>> platform power
>>> +		 * profile Balanced
>>> +		 */
>>> +		asus_wmi_write_aipt_mode(asus, AIPT_STANDARD);
>>> +	}
>>> +
>>>    	return 0;
>>>    }
>>>
>