linux-kernel - Re: [PATCH v1] usb: storage: use US_BULK_FLAG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024102056-yearly-caregiver-d684@gregkh>
Date: Sun, 20 Oct 2024 08:17:16 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Dingyan Li <18500469033@....com>
Cc: stern@...land.harvard.edu, linux-usb@...r.kernel.org,
	usb-storage@...ts.one-eyed-alien.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] usb: storage: use US_BULK_FLAG_OUT instead of
 constant values

On Sun, Oct 20, 2024 at 12:08:22AM +0800, Dingyan Li wrote:
> Macros with good names offer better readability. Besides, fix an error
> in the comments. In the flags, direction is in bit 7 instead of bit 0.

That means this should be at least 2 different patches please.
Remember, each change only does one logical thing.

thanks,

greg k-h