| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202410201515.SaOuSc9G-lkp@intel.com>
Date: Sun, 20 Oct 2024 15:46:31 +0800
From: kernel test robot <lkp@...el.com>
To: Shyam Sundar S K <Shyam-sundar.S-k@....com>,
Alexandre Belloni <alexandre.belloni@...tlin.com>,
Jarkko Nikula <jarkko.nikula@...ux.intel.com>
Cc: oe-kbuild-all@...ts.linux.dev, Sanket.Goswami@....com,
linux-i3c@...ts.infradead.org, linux-kernel@...r.kernel.org,
Shyam Sundar S K <Shyam-sundar.S-k@....com>
Subject: Re: [PATCH 3/6] i3c: master: Add ACPI support to i3c subsystem
Hi Shyam,
kernel test robot noticed the following build errors:
[auto build test ERROR on linus/master]
[also build test ERROR on v6.12-rc3 next-20241018]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Shyam-Sundar-S-K/i3c-dw-Add-support-for-AMDI0015-ACPI-ID/20241017-230810
base: linus/master
patch link: https://lore.kernel.org/r/20241017150330.3035568-4-Shyam-sundar.S-k%40amd.com
patch subject: [PATCH 3/6] i3c: master: Add ACPI support to i3c subsystem
config: arc-randconfig-001-20241020 (https://download.01.org/0day-ci/archive/20241020/202410201515.SaOuSc9G-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241020/202410201515.SaOuSc9G-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410201515.SaOuSc9G-lkp@intel.com/
All error/warnings (new ones prefixed by >>):
drivers/i3c/master/dw-i3c-master.c: In function 'dw_i3c_common_probe':
>> drivers/i3c/master/dw-i3c-master.c:1606:32: error: implicit declaration of function 'acpi_device_handle'; did you mean 'acpi_fwnode_handle'? [-Werror=implicit-function-declaration]
1606 | master->base.ahandle = acpi_device_handle(ACPI_COMPANION(&pdev->dev));
| ^~~~~~~~~~~~~~~~~~
| acpi_fwnode_handle
>> drivers/i3c/master/dw-i3c-master.c:1606:30: warning: assignment to 'acpi_handle' {aka 'void *'} from 'int' makes pointer from integer without a cast [-Wint-conversion]
1606 | master->base.ahandle = acpi_device_handle(ACPI_COMPANION(&pdev->dev));
| ^
cc1: some warnings being treated as errors
vim +1606 drivers/i3c/master/dw-i3c-master.c
1545
1546 int dw_i3c_common_probe(struct dw_i3c_master *master,
1547 struct platform_device *pdev)
1548 {
1549 int ret, irq;
1550
1551 if (!master->platform_ops)
1552 master->platform_ops = &dw_i3c_platform_ops_default;
1553
1554 master->dev = &pdev->dev;
1555
1556 master->regs = devm_platform_ioremap_resource(pdev, 0);
1557 if (IS_ERR(master->regs))
1558 return PTR_ERR(master->regs);
1559
1560 master->core_clk = devm_clk_get_enabled(&pdev->dev, NULL);
1561 if (IS_ERR(master->core_clk))
1562 return PTR_ERR(master->core_clk);
1563
1564 master->pclk = devm_clk_get_optional_enabled(&pdev->dev, "pclk");
1565 if (IS_ERR(master->pclk))
1566 return PTR_ERR(master->pclk);
1567
1568 master->core_rst = devm_reset_control_get_optional_exclusive(&pdev->dev,
1569 "core_rst");
1570 if (IS_ERR(master->core_rst))
1571 return PTR_ERR(master->core_rst);
1572
1573 reset_control_deassert(master->core_rst);
1574
1575 spin_lock_init(&master->xferqueue.lock);
1576 INIT_LIST_HEAD(&master->xferqueue.list);
1577
1578 writel(INTR_ALL, master->regs + INTR_STATUS);
1579 irq = platform_get_irq(pdev, 0);
1580 ret = devm_request_irq(&pdev->dev, irq,
1581 dw_i3c_master_irq_handler, IRQF_SHARED,
1582 dev_name(&pdev->dev), master);
1583 if (ret)
1584 goto err_assert_rst;
1585
1586 platform_set_drvdata(pdev, master);
1587
1588 pm_runtime_set_autosuspend_delay(&pdev->dev, RPM_AUTOSUSPEND_TIMEOUT);
1589 pm_runtime_use_autosuspend(&pdev->dev);
1590 pm_runtime_set_active(&pdev->dev);
1591 pm_runtime_enable(&pdev->dev);
1592
1593 /* Information regarding the FIFOs/QUEUEs depth */
1594 ret = readl(master->regs + QUEUE_STATUS_LEVEL);
1595 master->caps.cmdfifodepth = QUEUE_STATUS_LEVEL_CMD(ret);
1596
1597 ret = readl(master->regs + DATA_BUFFER_STATUS_LEVEL);
1598 master->caps.datafifodepth = DATA_BUFFER_STATUS_LEVEL_TX(ret);
1599
1600 ret = readl(master->regs + DEVICE_ADDR_TABLE_POINTER);
1601 master->datstartaddr = ret;
1602 master->maxdevs = ret >> 16;
1603 master->free_pos = GENMASK(master->maxdevs - 1, 0);
1604
1605 ACPI_COMPANION_SET(&master->base.dev, ACPI_COMPANION(&pdev->dev));
> 1606 master->base.ahandle = acpi_device_handle(ACPI_COMPANION(&pdev->dev));
1607 if (!master->base.ahandle)
1608 dev_err(&pdev->dev, "Failed to get acpi device handle\n");
1609
1610 INIT_WORK(&master->hj_work, dw_i3c_hj_work);
1611 ret = i3c_master_register(&master->base, &pdev->dev,
1612 &dw_mipi_i3c_ops, false);
1613 if (ret)
1614 goto err_disable_pm;
1615
1616 return 0;
1617
1618 err_disable_pm:
1619 pm_runtime_disable(&pdev->dev);
1620 pm_runtime_set_suspended(&pdev->dev);
1621 pm_runtime_dont_use_autosuspend(&pdev->dev);
1622
1623 err_assert_rst:
1624 reset_control_assert(master->core_rst);
1625
1626 return ret;
1627 }
1628 EXPORT_SYMBOL_GPL(dw_i3c_common_probe);
1629
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists