linux-kernel - Re: [PATCH net-next v2 07/18] net: Register system page pool as an XDP memory model

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6935ab95-c723-4abe-9143-1e7665190b83@intel.com>
Date: Mon, 21 Oct 2024 16:00:46 +0200
From: Alexander Lobakin <aleksander.lobakin@...el.com>
To: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
CC: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
	<edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Toke Høiland-Jørgensen
	<toke@...hat.com>, Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann
	<daniel@...earbox.net>, John Fastabend <john.fastabend@...il.com>, "Andrii
 Nakryiko" <andrii@...nel.org>, Stanislav Fomichev <sdf@...ichev.me>, "Magnus
 Karlsson" <magnus.karlsson@...el.com>,
	<nex.sw.ncis.osdt.itp.upstreaming@...el.com>, <bpf@...r.kernel.org>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v2 07/18] net: Register system page pool as an
 XDP memory model

From: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
Date: Thu, 17 Oct 2024 13:32:03 +0200

> On Tue, Oct 15, 2024 at 04:53:39PM +0200, Alexander Lobakin wrote:
>> From: Toke Høiland-Jørgensen <toke@...hat.com>
>>
>> To make the system page pool usable as a source for allocating XDP
>> frames, we need to register it with xdp_reg_mem_model(), so that page
>> return works correctly. This is done in preparation for using the system
>> page pool for the XDP live frame mode in BPF_TEST_RUN; for the same
>> reason, make the per-cpu variable non-static so we can access it from
>> the test_run code as well.
> 
> Again, to me BPF_TEST_RUN has nothing to do with libeth/idpf XDP support
> :<

Sorry, I forgot to adjust the commit message =\

Registering system page_pools as memory models is needed to introduce
generic XSk buff -> skb conversion (patch 15).

> 
>>
>> Signed-off-by: Toke Høiland-Jørgensen <toke@...hat.com>
>> Signed-off-by: Alexander Lobakin <aleksander.lobakin@...el.com>

Thanks,
Olek