linux-kernel - Re: [PATCH] platform/x86: dell-wmi: Ignore suspend notifications

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <40a76a97-b3e4-42cb-bee2-ca54731cc8ef@redhat.com>
Date: Mon, 21 Oct 2024 16:23:13 +0200
From: Hans de Goede <hdegoede@...hat.com>
To: Armin Wolf <W_Armin@....de>, pali@...nel.org
Cc: ilpo.jarvinen@...ux.intel.com, platform-driver-x86@...r.kernel.org,
 linux-kernel@...r.kernel.org, siddharth.manthan@...il.com
Subject: Re: [PATCH] platform/x86: dell-wmi: Ignore suspend notifications

Hi,

On 15-Oct-24 12:05 AM, Armin Wolf wrote:
> Some machines like the Dell G15 5155 emit WMI events when
> suspending/resuming. Ignore those WMI events.
> 
> Tested-by: siddharth.manthan@...il.com
> Signed-off-by: Armin Wolf <W_Armin@....de>

Thank you for your patch, I've applied this patch to my review-hans 
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

I will include this patch in my next fixes pull-req to Linus
for the current kernel development cycle.

Regards,

Hans




> ---
> For some reason mjg59@...f.ucam.org causes a local error in processing.
> ---
>  drivers/platform/x86/dell/dell-wmi-base.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/platform/x86/dell/dell-wmi-base.c b/drivers/platform/x86/dell/dell-wmi-base.c
> index 502783a7adb1..24fd7ffadda9 100644
> --- a/drivers/platform/x86/dell/dell-wmi-base.c
> +++ b/drivers/platform/x86/dell/dell-wmi-base.c
> @@ -264,6 +264,15 @@ static const struct key_entry dell_wmi_keymap_type_0010[] = {
>  	/*Speaker Mute*/
>  	{ KE_KEY, 0x109, { KEY_MUTE} },
> 
> +	/* S2Idle screen off */
> +	{ KE_IGNORE, 0x120, { KEY_RESERVED }},
> +
> +	/* Leaving S4 or S2Idle suspend */
> +	{ KE_IGNORE, 0x130, { KEY_RESERVED }},
> +
> +	/* Entering S2Idle suspend */
> +	{ KE_IGNORE, 0x140, { KEY_RESERVED }},
> +
>  	/* Mic mute */
>  	{ KE_KEY, 0x150, { KEY_MICMUTE } },
> 
> --
> 2.39.5
>