linux-kernel - [PATCH][next] Input: serio_raw: Fix uninitialized variable 'written'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20241021144103.928386-1-colin.i.king@gmail.com>
Date: Mon, 21 Oct 2024 15:41:03 +0100
From: Colin Ian King <colin.i.king@...il.com>
To: Dmitry Torokhov <dmitry.torokhov@...il.com>,
	linux-input@...r.kernel.org
Cc: kernel-janitors@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH][next] Input: serio_raw: Fix uninitialized variable 'written'

The variable written is not initialized and subsequent increments of the
variable are using an uninitialized value. Fix this by initializating it
at the start of the function.

Fixes: 5b53a9d40c4f ("Input: serio_raw - use guard notation for locks and other resources")
Signed-off-by: Colin Ian King <colin.i.king@...il.com>
---
 drivers/input/serio/serio_raw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/serio/serio_raw.c b/drivers/input/serio/serio_raw.c
index e058fef07f57..4d6395088986 100644
--- a/drivers/input/serio/serio_raw.c
+++ b/drivers/input/serio/serio_raw.c
@@ -185,7 +185,7 @@ static ssize_t serio_raw_write(struct file *file, const char __user *buffer,
 {
 	struct serio_raw_client *client = file->private_data;
 	struct serio_raw *serio_raw = client->serio_raw;
-	int written;
+	int written = 0;
 	unsigned char c;
 
 	scoped_guard(mutex_intr, &serio_raw_mutex) {
-- 
2.39.5