linux-kernel - Re: [PATCH v6 3/7] mfd: Add new driver for MAX77705 PMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABTCjFBpdMv6Qi3CLYNukMn+J1FwhbAg0hMy075Dt0H-g_hrUw@mail.gmail.com>
Date: Mon, 21 Oct 2024 18:04:39 +0300
From: Dzmitry Sankouski <dsankouski@...il.com>
To: Lee Jones <lee@...nel.org>
Cc: Sebastian Reichel <sre@...nel.org>, Chanwoo Choi <cw00.choi@...sung.com>, 
	Krzysztof Kozlowski <krzk@...nel.org>, Rob Herring <robh@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Dmitry Torokhov <dmitry.torokhov@...il.com>, Pavel Machek <pavel@....cz>, linux-pm@...r.kernel.org, 
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-input@...r.kernel.org, linux-leds@...r.kernel.org, 
	Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH v6 3/7] mfd: Add new driver for MAX77705 PMIC

> > diff --git a/drivers/mfd/max77705.c b/drivers/mfd/max77705.c
> > new file mode 100644
> > index 000000000000..553f20a6cdd5
> > --- /dev/null
> > +++ b/drivers/mfd/max77705.c
> > @@ -0,0 +1,248 @@
> > +// SPDX-License-Identifier: GPL-2.0+
> > +//
> > +// max77705.c - mfd core driver for the MAX77705
>
(...)
> > +// Copyright (C) 2024 Dzmitry Sankouski <dsankouski@...il.com>
>
> Only the SPDX in C++ comments please.
>
This conflicts with https://patchwork.kernel.org/comment/25898728/
> > +
(...)

> > +++ b/include/linux/mfd/max77705-private.h
> > @@ -0,0 +1,180 @@
> > +/* SPDX-License-Identifier: GPL-2.0 */
> > +//
> > +// Maxim MAX77705 definitions.
> > +//
> > +// Copyright (C) 2015 Samsung Electronics, Inc.
> > +// Copyright (C) 2024 Dzmitry Sankouski <dsankouski@...il.com>
>
> No C++ please.

This conflicts with https://patchwork.kernel.org/comment/25898728/

>
> > +
> > +#ifndef __LINUX_MFD_MAX77705_PRIV_H
> > +#define __LINUX_MFD_MAX77705_PRIV_H
> > +
> > +#include <linux/pm.h>
> > +
> > +#define MAX77705_SRC_IRQ_CHG BIT(0)
> > +#define MAX77705_SRC_IRQ_TOP BIT(1)
> > +#define MAX77705_SRC_IRQ_FG  BIT(2)
> > +#define MAX77705_SRC_IRQ_USBC        BIT(3)
> > +#define MAX77705_SRC_IRQ_ALL (MAX77705_SRC_IRQ_CHG | MAX77705_SRC_IRQ_TOP | \
> > +                             MAX77705_SRC_IRQ_FG | MAX77705_SRC_IRQ_USBC)
> > +
> > +// MAX77705_PMIC_REG_PMICREV register
>
> No C++ please.

This conflicts with https://patchwork.kernel.org/comment/25898728/

-- 

Best regards,
Dzmitry