[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZxZ7h335O9hgB20l@PC2K9PVX.TheFacebook.com>
Date: Mon, 21 Oct 2024 12:04:23 -0400
From: Gregory Price <gourry@...rry.net>
To: David Hildenbrand <david@...hat.com>
Cc: x86@...nel.org, linux-kernel@...r.kernel.org,
linux-acpi@...r.kernel.org, linux-mm@...ck.org,
dan.j.williams@...el.com, ira.weiny@...el.com,
dave.hansen@...ux.intel.com, luto@...nel.org, peterz@...radead.org,
tglx@...utronix.de, mingo@...hat.com, bp@...en8.de, hpa@...or.com,
rafael@...nel.org, lenb@...nel.org, rppt@...nel.org,
akpm@...ux-foundation.org, alison.schofield@...el.com,
Jonathan.Cameron@...wei.com, rrichter@....com, ytcoode@...il.com,
haibo1.xu@...el.com, dave.jiang@...el.com
Subject: Re: [PATCH v2 2/3] x86: probe memblock size advisement value during
mm init
On Mon, Oct 21, 2024 at 10:46:38AM -0400, Gregory Price wrote:
> On Mon, Oct 21, 2024 at 01:12:26PM +0200, David Hildenbrand wrote:
> >
> > > + /* Consider hotplug advisement value (if set) */
> > > + order = memblock_probe_size_order();
> >
> > "size_order" is a very weird name. Just return a size?
> >
> > memory_block_advised_max_size()
> >
> > or sth like that?
> >
>
> There isn't technically an overall "max block size", nor any alignment
> requirements - so order was a nice way of enforcing 2-order alignment
> while also having the ability to get a -1/-EBUSY/whatever out.
>
> I can change it if it's a big sticking point - but that's my reasoning.
>
maybe change to
memory_block_advise_max_size
memory_block_probe_max_size
but still take in / return an order?
~Gregory
Powered by blists - more mailing lists