linux-kernel - Re: [PATCH 1/2] drm/vc4: Run default client setup for all variants.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPY8ntDc_s4pxBAVbSdDRDHMVWZHEdWw-283GxCiguz81NYBow@mail.gmail.com>
Date: Mon, 21 Oct 2024 17:10:57 +0100
From: Dave Stevenson <dave.stevenson@...pberrypi.com>
To: Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>
Cc: Raspberry Pi Kernel Maintenance <kernel-list@...pberrypi.com>, 
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, David Airlie <airlied@...il.com>, 
	Simona Vetter <simona@...ll.ch>, Javier Martinez Canillas <javierm@...hat.com>, dri-devel@...ts.freedesktop.org, 
	linux-kernel@...r.kernel.org, Maíra Canal <mcanal@...lia.com>
Subject: Re: [PATCH 1/2] drm/vc4: Run default client setup for all variants.

Hi Maxime & Thomas.

Sorry, I'm still learning the processes.

This patch and the 3 from
https://patchwork.freedesktop.org/series/139716/ are in drm-misc-next,
but they are fixes needed for 6.12.
Am I right in thinking I need to "dim cherry-pick" them to
drm-misc-fixes so they get merged there?

Thanks

  Dave

On Wed, 9 Oct 2024 at 13:15, Dave Stevenson
<dave.stevenson@...pberrypi.com> wrote:
>
> On Wed, 9 Oct 2024 at 12:02, Maíra Canal <mcanal@...lia.com> wrote:
> >
> > Hi Dave,
> >
> > On 10/2/24 12:06, Dave Stevenson wrote:
> > > Commit 45903624e9fc ("drm/vc4: Run DRM default client setup")
> > > only added DRM_FBDEV_DMA_DRIVER_OPS for the vc4 (Pi0-3) driver
> > > definition, which caused an issue on vc5 (Pi4) as there was no
> > > fbdev_probe function defined.
> > >
> > > Fixes: 45903624e9fc ("drm/vc4: Run DRM default client setup")
> > > Signed-off-by: Dave Stevenson <dave.stevenson@...pberrypi.com>
> >
> > Reviewed-by: Maíra Canal <mcanal@...lia.com>
>
> Applied to drm-misc-next.
>
> > Best Regards,
> > - Maíra
> >
> > > ---
> > >   drivers/gpu/drm/vc4/vc4_drv.c | 1 +
> > >   1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c
> > > index 13a1ecddbca3..a238f76a6073 100644
> > > --- a/drivers/gpu/drm/vc4/vc4_drv.c
> > > +++ b/drivers/gpu/drm/vc4/vc4_drv.c
> > > @@ -238,6 +238,7 @@ const struct drm_driver vc5_drm_driver = {
> > >   #endif
> > >
> > >       DRM_GEM_DMA_DRIVER_OPS_WITH_DUMB_CREATE(vc5_dumb_create),
> > > +     DRM_FBDEV_DMA_DRIVER_OPS,
> > >
> > >       .fops = &vc4_drm_fops,
> > >
> > >