linux-kernel - Re: [PATCH 2/2] remoteproc: k3-r5: Add compile testing support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4954e8a6-06dc-49db-afdb-93260539649a@ti.com>
Date: Mon, 21 Oct 2024 11:54:27 -0500
From: Andrew Davis <afd@...com>
To: Bjorn Andersson <andersson@...nel.org>,
        Mathieu Poirier
	<mathieu.poirier@...aro.org>
CC: <linux-remoteproc@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] remoteproc: k3-r5: Add compile testing support

On 10/16/24 11:41 AM, Andrew Davis wrote:
> This driver can be compile tested on non-K3 architectures as long
> as TI_SCI_PROTOCOL is not compiled as a module. Enable this here
> to improve this driver's build coverage.
> 
> Signed-off-by: Andrew Davis <afd@...com>
> ---
>   drivers/remoteproc/Kconfig | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
> index 0ac1c8a6e4581..83962a114dc9f 100644
> --- a/drivers/remoteproc/Kconfig
> +++ b/drivers/remoteproc/Kconfig
> @@ -355,7 +355,8 @@ config TI_K3_M4_REMOTEPROC
>   
>   config TI_K3_R5_REMOTEPROC
>   	tristate "TI K3 R5 remoteproc support"
> -	depends on ARCH_K3
> +	depends on ARCH_K3 || COMPILE_TEST

kernel test robot is giving some extra warning now around the lines:

memset(core->mem[0].cpu_addr, 0x00, core->mem[0].size);

This was already an issue and threw warnings even on ARM64 builds, but
now that we can compile test on other archs, all those will start
complaining too.

Fix is easy, just s/memset()/memset_io() here. I'll give that a test
run then send a patch.

Andrew

> +	depends on TI_SCI_PROTOCOL || (COMPILE_TEST && TI_SCI_PROTOCOL=n)
>   	depends on OMAP2PLUS_MBOX
>   	help
>   	  Say m here to support TI's R5F remote processor subsystems