linux-kernel - Re: [PATCH v2 1/1] PCI: Improve printout in pdev_sort

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20241021175328.GA839797@bhelgaas>
Date: Mon, 21 Oct 2024 12:53:28 -0500
From: Bjorn Helgaas <helgaas@...nel.org>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: Jonathan Cameron <Jonathan.Cameron@...wei.com>,
	Philipp Stanner <pstanner@...hat.com>, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/1] PCI: Improve printout in pdev_sort_resources()

Oops, I inadvertently removed the cc list when I sent the response
below.  Adding it back here.

On Fri, Oct 18, 2024 at 06:42:59PM -0500, Bjorn Helgaas wrote:
> [+cc Jonathan]
> 
> On Thu, Oct 17, 2024 at 12:55:45PM +0300, Ilpo Järvinen wrote:
> > Use pci_resource_name() helper in pdev_sort_resources() to print
> > resources in user-friendly format. Also replace the vague "bogus
> > alignment" with a more precise explanation of the problem.
> > 
> > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
> 
> Applied with Philipp's reviewed-by to pci/resource for v6.13, thanks!
> 
> Happy to add yours, too, Jonathan, if you want.  You basically said
> so, but I don't want to presume :)
> 
> > ---
> > 
> > v2:
> > - Place colon after %s %pR to be consistent with other printouts
> > - Replace vague "bogus alignment" with the exact cause
> > 
> >  drivers/pci/setup-bus.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c
> > index 23082bc0ca37..0fd286f79674 100644
> > --- a/drivers/pci/setup-bus.c
> > +++ b/drivers/pci/setup-bus.c
> > @@ -134,6 +134,7 @@ static void pdev_sort_resources(struct pci_dev *dev, struct list_head *head)
> >  	int i;
> >  
> >  	pci_dev_for_each_resource(dev, r, i) {
> > +		const char *r_name = pci_resource_name(dev, i);
> >  		struct pci_dev_resource *dev_res, *tmp;
> >  		resource_size_t r_align;
> >  		struct list_head *n;
> > @@ -146,8 +147,8 @@ static void pdev_sort_resources(struct pci_dev *dev, struct list_head *head)
> >  
> >  		r_align = pci_resource_alignment(dev, r);
> >  		if (!r_align) {
> > -			pci_warn(dev, "BAR %d: %pR has bogus alignment\n",
> > -				 i, r);
> > +			pci_warn(dev, "%s %pR: alignment must not be zero\n",
> > +				 r_name, r);
> >  			continue;
> >  		}
> >  
> > -- 
> > 2.39.5
> >