linux-kernel - Re: [PATCH] dt-bindings: soc: bcm: Convert to Dt schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <pyizqjpxjgd6zdrhh65fklmyrxgxmlu2wmv7tzpdhdkwh7ifn6@efvaxhpekxtb>
Date: Mon, 21 Oct 2024 18:13:17 +0000
From: Karan Sanghavi <karansanghvi98@...il.com>
To: Conor Dooley <conor@...nel.org>
Cc: Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Florian Fainelli <florian.fainelli@...adcom.com>, 
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, Ray Jui <rjui@...adcom.com>, 
	Scott Branden <sbranden@...adcom.com>, devicetree@...r.kernel.org, linux-rpi-kernel@...ts.infradead.org, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, 
	Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] dt-bindings: soc: bcm: Convert to Dt schema

On Mon, Oct 21, 2024 at 12:39:28PM +0100, Conor Dooley wrote:
> On Sat, Oct 19, 2024 at 07:51:18PM +0000, Karan Sanghavi wrote:
> 
> $subject: dt-bindings: soc: bcm: Convert to Dt schema
> 
> That's not specific enough about what binding you're converting here.
> 
Sure will make the changes. 

> > +maintainers:
> > +  - Karan Sanghavi <karansanghvi98@...il.com>
> 
> Why not the maintainer of the original binding?
>

I had read somewhere that who ever converts the binding file becomes
its maintainer thus added my name but will add the original binding
file's maintainer name which can actually help in maintaining this file.

> > +
> > +description: |
> 
> The | here serves no purpose, as you have no formatting to preserve.
> 
Sure will make the changes.
> > +  The Raspberry Pi power domain driver manages power for various subsystems
> > +  in the Raspberry Pi BCM2835 SoC.
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - raspberrypi,bcm2835-power
> > +
> > +  firmware:
> > +    $ref: /schemas/types.yaml#/definitions/phandle
> > +
> > +  '#power-domain-cells':
> > +    const: 1
> > +
> > +required:
> > +  - compatible
> > +  - firmware
> > +  - "#power-domain-cells"
> > +
> > +unevaluatedProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/power/raspberrypi-power.h>
> 
> What do you use from this header?
>
Example for power node
power: power {
        compatible = "raspberrypi,bcm2835-power";
        firmware = <&firmware>;
        #power-domain-cells = <1>;
   };

Example for using the power domain

&usb {
        power-domains = <&power RPI_POWER_DOMAIN_USB>;
   };

We need the header for referring the power domain defines in the sub
nodes.

I didn't understood exactly how should I include the usb example thus
omitted it but if required can you please let me know how to add them.

> > +    power: power {
> 
> The label here should be removed, it is never referenced.
> 
> Cheers,
> Conor.

Thank you,
Karan.