linux-kernel - Re: [PATCH] arm64: dts: rockchip: Drop invalid clock-names from es8388 codec nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1624395d-f4e9-4c82-a5ef-c05e2f3505db@collabora.com>
Date: Mon, 21 Oct 2024 21:50:56 +0300
From: Cristian Ciocaltea <cristian.ciocaltea@...labora.com>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: kernel@...labora.com, linux-arm-kernel@...ts.infradead.org,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, devicetree@...r.kernel.org,
 Heiko Stuebner <heiko@...ech.de>, linux-rockchip@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: rockchip: Drop invalid clock-names from
 es8388 codec nodes

On 10/21/24 8:58 PM, Rob Herring (Arm) wrote:
> 
> On Sat, 19 Oct 2024 03:38:10 +0300, Cristian Ciocaltea wrote:
>> The binding for Everest ES8328/ES8388 audio CODEC doesn't support the
>> 'clock-names' property:
>>
>>   rk3588-orangepi-5-plus.dtb: audio-codec@11: 'clock-names' does not match any of the regexes: 'pinctrl-[0-9]+'
>>     from schema $id: http://devicetree.org/schemas/sound/everest,es8328.yaml#
>>
>> Since the related audio driver is also not making use of it, drop the
>> invalid property from all es8388 codec nodes.
>>
>> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@...labora.com>
>> ---
>> Several DT fixes involving the usage of the Everest ES8328/ES8388 audio
>> CODEC.
>> ---
>>  arch/arm64/boot/dts/rockchip/rk3399-roc-pc-plus.dts      | 1 -
>>  arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts  | 1 -
>>  arch/arm64/boot/dts/rockchip/rk3588-quartzpro64.dts      | 1 -
>>  arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dts | 1 -
>>  4 files changed, 4 deletions(-)
>>
> 
> 
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
> 
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to reply
> unless the platform maintainer has comments.
> 
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
> 
>   pip3 install dtschema --upgrade
> 
> 
> New warnings running 'make CHECK_DTBS=y rockchip/rk3399-roc-pc-plus.dtb rockchip/rk3588-orangepi-5-plus.dtb rockchip/rk3588-quartzpro64.dtb rockchip/rk3588s-indiedroid-nova.dtb' for 20241019-es8328-dt-fixes-v1-1-ca77d5ce21ad@...labora.com:
> 
> arch/arm64/boot/dts/rockchip/rk3588s-indiedroid-nova.dtb: audio-codec@11: 'port' does not match any of the regexes: 'pinctrl-[0-9]+'
> 	from schema $id: http://devicetree.org/schemas/sound/everest,es8328.yaml#
 
This warning is unrelated, but eventually fixed via:

https://lore.kernel.org/lkml/20241019-es8328-doc-port-v1-1-25c1d1b5c65c@collabora.com/

Regards,
Cristian