linux-kernel - Re: [PATCH v5 1/3] selftests: livepatch: rename KLP_SYSFS_DIR to SYSFS_KLP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <da00cde9-ca61-266d-2185-7664c1bade68@redhat.com>
Date: Mon, 21 Oct 2024 14:55:43 -0400
From: Joe Lawrence <joe.lawrence@...hat.com>
To: Michael Vetter <mvetter@...e.com>, linux-kselftest@...r.kernel.org,
 live-patching@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 1/3] selftests: livepatch: rename KLP_SYSFS_DIR to
 SYSFS_KLP_DIR

On 10/17/24 16:01, Michael Vetter wrote:
> @@ -246,12 +246,12 @@ function unload_lp() {
>  function disable_lp() {
>  	local mod="$1"
>  
> -	log "% echo 0 > /sys/kernel/livepatch/$mod/enabled"
> -	echo 0 > /sys/kernel/livepatch/"$mod"/enabled
> +	log "% echo 0 > $SYSFS_KLP_DIR/$mod/enabled"
> +	echo 0 > "$SYSFS_KLP_DIR"/mod"/enabled

Nit: syntax error here, should be (quotation fix and $mod is a variable):

  echo 0 > "$SYSFS_KLP_DIR/$mod/enabled"

With that, the test works for me.

-- 
Joe