linux-kernel - Re: [PATCH] clk: qcom: clk-alpha-pll: fix alpha mode configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f2a1dcc6-247b-44fd-97ae-977f8b3c4d41@gmail.com>
Date: Mon, 21 Oct 2024 21:03:03 +0200
From: Gabor Juhos <j4g8y7@...il.com>
To: Stephen Boyd <sboyd@...nel.org>, Bjorn Andersson <andersson@...nel.org>,
 Michael Turquette <mturquette@...libre.com>
Cc: linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
 linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] clk: qcom: clk-alpha-pll: fix alpha mode configuration

2024. 10. 21. 20:14 keltezéssel, Stephen Boyd írta:
> Quoting Gabor Juhos (2024-10-21 10:32:48)
>> Commit c45ae598fc16 ("clk: qcom: support for alpha mode configuration")
>> added support for configuring alpha mode, but it seems that the feature
>> was never working in practice.
>>
> [...]
>>
>> Applying the 'alpha_en_mask' fixes the initial rate of the PLLs showed
>> in the table above. Since the 'alpha_mode_mask' is not used by any driver
>> currently, that part of the change causes no functional changes.
>>
>> Cc: stable@...r.kernel.org
>> Fixes: c45ae598fc16 ("clk: qcom: support for alpha mode configuration")
>> Signed-off-by: Gabor Juhos <j4g8y7@...il.com>
>> ---
>> diff --git a/drivers/clk/qcom/clk-alpha-pll.c b/drivers/clk/qcom/clk-alpha-pll.c
>> index f9105443d7dbb104e3cb091e59f43df25999f8b3..03cc7aa092480bfdd9eaa986d44f0545944b3b89 100644
>> --- a/drivers/clk/qcom/clk-alpha-pll.c
>> +++ b/drivers/clk/qcom/clk-alpha-pll.c
>> @@ -421,6 +421,8 @@ void clk_alpha_pll_configure(struct clk_alpha_pll *pll, struct regmap *regmap,
>>         mask |= config->pre_div_mask;
>>         mask |= config->post_div_mask;
>>         mask |= config->vco_mask;
>> +       mask |= config->alpha_en_mask;
>> +       mask |= config->alpha_mode_mask;
>>  
> 
> This is https://lore.kernel.org/all/20241019-qcs615-mm-clockcontroller-v1-1-4cfb96d779ae@quicinc.com/

Oops, indeed. Sorry, I should have noticed that.

-Gabor