[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20241021190334.GA953710-robh@kernel.org>
Date: Mon, 21 Oct 2024 14:03:34 -0500
From: Rob Herring <robh@...nel.org>
To: Jim Quinlan <james.quinlan@...adcom.com>
Cc: linux-pci@...r.kernel.org, Nicolas Saenz Julienne <nsaenz@...nel.org>,
Bjorn Helgaas <bhelgaas@...gle.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
bcm-kernel-feedback-list@...adcom.com, jim2101024@...il.com,
Florian Fainelli <florian.fainelli@...adcom.com>,
Lorenzo Pieralisi <lpieralisi@...nel.org>,
Krzysztof WilczyĆski <kw@...ux.com>,
Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
"moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE" <linux-arm-kernel@...ts.infradead.org>,
"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" <linux-rpi-kernel@...ts.infradead.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>,
open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] RFC: dt bindings: Add property "brcm,gen3-eq-presets"
On Fri, Oct 18, 2024 at 02:22:45PM -0400, Jim Quinlan wrote:
> Support configuration of the GEN3 preset equalization settings, aka the
> Lane Equalization Control Register(s) of the Secondary PCI Express
> Extended Capability. These registers are of type HwInit/RsvdP and
> typically set by FW. In our case they are set by our RC host bridge
> driver using internal registers.
>
> Signed-off-by: Jim Quinlan <james.quinlan@...adcom.com>
> ---
> .../devicetree/bindings/pci/brcm,stb-pcie.yaml | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> index 0925c520195a..f965ad57f32f 100644
> --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> @@ -104,6 +104,18 @@ properties:
> minItems: 1
> maxItems: 3
>
> + brcm,gen3-eq-presets:
> + description: |
> + A u16 array giving the GEN3 equilization presets, one for each lane.
> + These values are destined for the 16bit registers known as the
> + Lane Equalization Control Register(s) of the Secondary PCI Express
> + Extended Capability. In the array, lane 0 is first term, lane 1 next,
> + etc. The contents of the entries reflect what is necessary for
> + the current board and SoC, and the details of each preset are
> + described in Section 7.27.4 of the PCI base spec, Revision 3.0.
If these are defined by the PCIe spec, then why is it Broadcom specific
property?
> +
> + $ref: /schemas/types.yaml#/definitions/uint16-array
minItems: 1
maxItems: 16
Last I saw, you can only have up to 16 lanes.
Rob
Powered by blists - more mailing lists