[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20241021192632.GA965116-robh@kernel.org>
Date: Mon, 21 Oct 2024 14:26:32 -0500
From: Rob Herring <robh@...nel.org>
To: James Calligeros <jcalligeros99@...il.com>
Cc: Martin Povišer <povik+lin@...ebit.org>,
David Rhodes <david.rhodes@...rus.com>,
Richard Fitzgerald <rf@...nsource.cirrus.com>,
Liam Girdwood <lgirdwood@...il.com>,
Mark Brown <broonie@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
asahi@...ts.linux.dev, linux-sound@...r.kernel.org,
patches@...nsource.cirrus.com, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, Hector Martin <marcan@...can.st>,
Neal Gompa <neal@...pa.dev>
Subject: Re: [PATCH v2 1/3] dt-bindings: sound: Add CS42L84 codec
On Sun, Oct 20, 2024 at 12:47:31AM +1000, James Calligeros wrote:
> From: Martin Povišer <povik+lin@...ebit.org>
>
> CS42L84 is a headphone jack codec made by Cirrus Logic and seen in Apple
> computer models starting with 2021 Macbook Pros. It is not a publicly
> documented part. To a degree the part is similar to the public CS42L42.
> (The L84 superseded L83 seen in earlier Apple models, and the L83 was
> pretty much the same as L42.)
Why can't this be added to
Documentation/devicetree/bindings/sound/cirrus,cs42l42.yaml?
I guess perhaps you don't know what the supplies look like? Do any of
the custom properties apply?
>
> Signed-off-by: Martin Povišer <povik+lin@...ebit.org>
> Signed-off-by: James Calligeros <jcalligeros99@...il.com>
> Reviewed-by: Neal Gompa <neal@...pa.dev>
> ---
> .../bindings/sound/cirrus,cs42l84.yaml | 56 +++++++++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 57 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/cirrus,cs42l84.yaml b/Documentation/devicetree/bindings/sound/cirrus,cs42l84.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..7f8338e8ae369bc529ac3cf35041d5a7b9f3e6d1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/cirrus,cs42l84.yaml
> @@ -0,0 +1,56 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/cirrus,cs42l84.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Cirrus Logic CS42L84 audio CODEC
> +
> +maintainers:
> + - Martin Povišer <povik+lin@...ebit.org>
> +
> +description: |
Don't need '|' if no formatting.
> + The CS42L84 is a headphone jack codec made by Cirrus Logic and embedded
> + in personal computers sold by Apple. It was first seen in 2021 Macbook
> + Pro models. It has stereo DAC for playback, mono ADC for capture, and
> + is somewhat similar to CS42L42 but with a different regmap.
> +
> +properties:
> + compatible:
> + enum:
> + - cirrus,cs42l84
> +
> + reg:
> + maxItems: 1
> +
> + reset-gpios:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + '#sound-dai-cells':
> + const: 0
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + jack_codec: codec@4b {
> + compatible = "cirrus,cs42l84";
> + reg = <0x4b>;
> + reset-gpios = <&pinctrl_nub 4 GPIO_ACTIVE_LOW>;
> + interrupts-extended = <&pinctrl_ap 180 IRQ_TYPE_LEVEL_LOW>;
> + #sound-dai-cells = <0>;
> + };
> + };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index c1a2c296446c0724a0c6e70c845e5e5e1e693fd5..f5f85714dc4e8ca9c60b3f6963b2cec1ea33fdd0 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2132,6 +2132,7 @@ L: asahi@...ts.linux.dev
> L: linux-sound@...r.kernel.org
> S: Maintained
> F: Documentation/devicetree/bindings/sound/adi,ssm3515.yaml
> +F: Documentation/devicetree/bindings/sound/cirrus,cs42l84.yaml
> F: Documentation/devicetree/bindings/sound/apple,*
> F: sound/soc/apple/*
> F: sound/soc/codecs/cs42l83-i2c.c
>
> --
> 2.47.0
>
Powered by blists - more mailing lists