linux-kernel - Re: [PATCH] module: .strtab must be null terminated

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zxaxg5KZy9spBRM4@bombadil.infradead.org>
Date: Mon, 21 Oct 2024 12:54:43 -0700
From: Luis Chamberlain <mcgrof@...nel.org>
To: Tobias Stoeckmann <tobias@...eckmann.org>
Cc: linux-modules@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] module: .strtab must be null terminated

On Sat, Oct 19, 2024 at 04:14:40PM +0200, Tobias Stoeckmann wrote:
> The string table must be NUL-terminated, just like the section name table.
> 
> Signed-off-by: Tobias Stoeckmann <tobias@...eckmann.org>
> ---
> In order to create a proof of concept, which I can't get into a simple
> script right now, it's easiest to move '.strtab' to the end of the module
> file, write as many 'A' characters at the end as required according to the
> section size, and try to insert the module.
> 
> In dmesg, you can see lines like:
> 
> ```
> poc: Unknown symbol AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA\xc6\xe9<\xfe\xff\xff\x8b
> \xff\xc1\xe9\x03\xf3H\xa5\xeb\xa1I\x8b~ \xe8 (err -2)
> ```
> ---

Thanks can you post rebased aginst modules-next on the modules tree [0].
But please consider sending both patches and the new test one in a
series, I'll reply shortly about the other patch.

[0] https://git.kernel.org/pub/scm/linux/kernel/git/modules/linux.git/

  Luisk