linux-kernel - Re: [PATCH] KVM: selftests: x86: Avoid using SSE/AVX instructions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5071a694-150b-4f6f-8e48-8b96998bdd23@sirena.org.uk>
Date: Mon, 21 Oct 2024 21:33:54 +0100
From: Mark Brown <broonie@...nel.org>
To: Vitaly Kuznetsov <vkuznets@...hat.com>
Cc: kvm@...r.kernel.org, Paolo Bonzini <pbonzini@...hat.com>,
	Sean Christopherson <seanjc@...gle.com>,
	Jan Richter <jarichte@...hat.com>, linux-kernel@...r.kernel.org,
	Aishwarya.TCV@....com, torvalds@...ux-foundation.org
Subject: Re: [PATCH] KVM: selftests: x86: Avoid using SSE/AVX instructions

On Mon, Oct 21, 2024 at 07:32:17PM +0100, Mark Brown wrote:
> On Fri, Sep 20, 2024 at 05:44:22PM +0200, Vitaly Kuznetsov wrote:
> 
> > Some distros switched gcc to '-march=x86-64-v3' by default and while it's
> > hard to find a CPU which doesn't support it today, many KVM selftests fail
> > with
> 
> This patch, which is queued in -next as 9a400068a1586bc4 targeted as a
> fix, breaks the build on non-x86 architectures:

This patch is now in Linus' tree, having been applied on Sunday and as a
result appeared in -next today.

> 
> aarch64-linux-gnu-gcc -D_GNU_SOURCE=  -Wall -Wstrict-prototypes -Wuninitialized 
> -O2 -g -std=gnu99 -Wno-gnu-variable-sized-type-not-at-end -MD -MP -DCONFIG_64BIT
>  -fno-builtin-memcmp -fno-builtin-memcpy -fno-builtin-memset -fno-builtin-strnlen -fno-stack-protector -fno-PIE -I/build/stage/linux/tools/testing/selftests/../../../tools/include -I/build/stage/linux/tools/testing/selftests/../../../tools/arch/arm64/include -I/build/stage/linux/tools/testing/selftests/../../../usr/include/ -Iinclude -Iaarch64 -Iinclude/aarch64 -I ../rseq -I..  -march=x86-64-v2 -isystem /build/stage/build-work/usr/include -I/build/stage/linux/tools/testing/selftests/../../../tools/arch/arm64/include/generated/   -c aarch64/aarch32_id_regs.c -o /build/stage/build-work/kselftest/kvm/aarch64/aarch32_id_regs.o
> cc1: error: unknown value ‘x86-64-v2’ for ‘-march’
> 
> This is because:
> 
> > diff --git a/tools/testing/selftests/kvm/Makefile b/tools/testing/selftests/kvm/Makefile
> > index 48d32c5aa3eb..3f1b24ed7245 100644
> > --- a/tools/testing/selftests/kvm/Makefile
> > +++ b/tools/testing/selftests/kvm/Makefile
> > @@ -238,6 +238,7 @@ CFLAGS += -Wall -Wstrict-prototypes -Wuninitialized -O2 -g -std=gnu99 \
> >  	-fno-stack-protector -fno-PIE -I$(LINUX_TOOL_INCLUDE) \
> >  	-I$(LINUX_TOOL_ARCH_INCLUDE) -I$(LINUX_HDR_PATH) -Iinclude \
> >  	-I$(<D) -Iinclude/$(ARCH_DIR) -I ../rseq -I.. $(EXTRA_CFLAGS) \
> > +	-march=x86-64-v2 \
> >  	$(KHDR_INCLUDES)
> >  ifeq ($(ARCH),s390)
> >  	CFLAGS += -march=z10
> 
> unconditionally sets an architecture specific flag which is obviously
> not going to work on anything except x86.  This should be set under an
> architecture check like the similar S/390 flag that can be seen in the
> context for the diff.



Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)