linux-kernel - Re: [PATCH v4 23/28] dax/bus: Factor out dev dax resize logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6716c4c333033_7253d29447@iweiny-mobl.notmuch>
Date: Mon, 21 Oct 2024 16:16:51 -0500
From: Ira Weiny <ira.weiny@...el.com>
To: Jonathan Cameron <Jonathan.Cameron@...wei.com>, Ira Weiny
	<ira.weiny@...el.com>
CC: Dave Jiang <dave.jiang@...el.com>, Fan Ni <fan.ni@...sung.com>, "Navneet
 Singh" <navneet.singh@...el.com>, Jonathan Corbet <corbet@....net>, "Andrew
 Morton" <akpm@...ux-foundation.org>, Dan Williams <dan.j.williams@...el.com>,
	Davidlohr Bueso <dave@...olabs.net>, Alison Schofield
	<alison.schofield@...el.com>, Vishal Verma <vishal.l.verma@...el.com>,
	<linux-btrfs@...r.kernel.org>, <linux-cxl@...r.kernel.org>,
	<linux-doc@...r.kernel.org>, <nvdimm@...ts.linux.dev>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 23/28] dax/bus: Factor out dev dax resize logic

Jonathan Cameron wrote:
> On Mon, 07 Oct 2024 18:16:29 -0500
> Ira Weiny <ira.weiny@...el.com> wrote:

[snip]

> > Signed-off-by: Ira Weiny <ira.weiny@...el.com>
> > ---
> > Changes:
> > [Jonathan: Fix handling of alloc]
> 
> Trivial comments inline.
> Not an area I know much about, so treat this one as a 'smells ok'
> type of tag.

NP

> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
>

Thanks

> 
> > +
> > +static ssize_t dev_dax_resize(struct dax_region *dax_region,
> > +		struct dev_dax *dev_dax, resource_size_t size)
> > +{
> > +	resource_size_t avail = dax_region_avail_size(dax_region), to_alloc;
> 	resource_size_t to_alloc;
> 
> on it's own line.  That was hard to spot all the way over there.
> Obviously this was in original code, but maybe slip a tidy up in whilst
> you are moving it?

Yea fixed up.
Ira