linux-kernel - Re: [PATCH v2] LoongArch: Fix cpu hotplug issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202410220508.9OO5jJgk-lkp@intel.com>
Date: Tue, 22 Oct 2024 06:01:49 +0800
From: kernel test robot <lkp@...el.com>
To: Bibo Mao <maobibo@...ngson.cn>, Huacai Chen <chenhuacai@...nel.org>,
	Jianmin Lv <lvjianmin@...ngson.cn>
Cc: oe-kbuild-all@...ts.linux.dev, loongarch@...ts.linux.dev,
	linux-kernel@...r.kernel.org, lixianglai@...ngson.cn,
	WANG Xuerui <kernel@...0n.name>
Subject: Re: [PATCH v2] LoongArch: Fix cpu hotplug issue

Hi Bibo,

kernel test robot noticed the following build errors:

[auto build test ERROR on 42f7652d3eb527d03665b09edac47f85fb600924]

url:    https://github.com/intel-lab-lkp/linux/commits/Bibo-Mao/LoongArch-Fix-cpu-hotplug-issue/20241021-160525
base:   42f7652d3eb527d03665b09edac47f85fb600924
patch link:    https://lore.kernel.org/r/20241021080418.644342-1-maobibo%40loongson.cn
patch subject: [PATCH v2] LoongArch: Fix cpu hotplug issue
config: loongarch-allnoconfig (https://download.01.org/0day-ci/archive/20241022/202410220508.9OO5jJgk-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241022/202410220508.9OO5jJgk-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410220508.9OO5jJgk-lkp@intel.com/

All errors (new ones prefixed by >>):

   arch/loongarch/kernel/setup.c: In function 'topo_add_cpu':
>> arch/loongarch/kernel/setup.c:383:9: error: '__cpu_logical_map' undeclared (first use in this function); did you mean 'cpu_logical_map'?
     383 |         __cpu_logical_map[possible_cpus] = physid;
         |         ^~~~~~~~~~~~~~~~~
         |         cpu_logical_map
   arch/loongarch/kernel/setup.c:383:9: note: each undeclared identifier is reported only once for each function it appears in
   arch/loongarch/kernel/setup.c: In function 'topo_init':
   arch/loongarch/kernel/setup.c:391:9: error: '__cpu_logical_map' undeclared (first use in this function); did you mean 'cpu_logical_map'?
     391 |         __cpu_logical_map[0] = loongson_sysconf.boot_cpu_id;
         |         ^~~~~~~~~~~~~~~~~
         |         cpu_logical_map


vim +383 arch/loongarch/kernel/setup.c

   364	
   365	int topo_add_cpu(int physid)
   366	{
   367		int cpu;
   368	
   369		if (!bsp_added && (physid == loongson_sysconf.boot_cpu_id)) {
   370			bsp_added = true;
   371			return 0;
   372		}
   373	
   374		cpu = topo_get_cpu(physid);
   375		if (cpu >= 0) {
   376			pr_warn("Adding duplicated physical cpuid 0x%x\n", physid);
   377			return -EEXIST;
   378		}
   379	
   380		if (possible_cpus >= nr_cpu_ids)
   381			return -ERANGE;
   382	
 > 383		__cpu_logical_map[possible_cpus] = physid;
   384		cpu = possible_cpus++;
   385		return cpu;
   386	}
   387	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki