lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CY8PR11MB71341C3DE209B2AEC27ACAAD89432@CY8PR11MB7134.namprd11.prod.outlook.com>
Date: Mon, 21 Oct 2024 06:29:01 +0000
From: "Zhuo, Qiuxu" <qiuxu.zhuo@...el.com>
To: "H. Peter Anvin" <hpa@...or.com>, "Mehta, Sohil" <sohil.mehta@...el.com>,
	"Luck, Tony" <tony.luck@...el.com>, "bp@...en8.de" <bp@...en8.de>
CC: "tglx@...utronix.de" <tglx@...utronix.de>, "dave.hansen@...ux.intel.com"
	<dave.hansen@...ux.intel.com>, "mingo@...hat.com" <mingo@...hat.com>,
	"x86@...nel.org" <x86@...nel.org>, "linux-edac@...r.kernel.org"
	<linux-edac@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 08/10] x86/mce: Remove the redundant zeroing
 assignments

> From: H. Peter Anvin <hpa@...or.com>
> [...]
> >This is a good tip to quickly check whether a cleanup of removing
> >unnecessary assignments changes the function. If there is no difference
> >in the text before and after the cleanup, then it's OK. Otherwise, the
> >cleanup probably changes the function in an unintended way.
> >
> >-Qiuxu
> >
> 
> Yes and no. Deleting things like redundant reinitialization should only be done
> if it makes the code clearer. You can think of the redundant statements as
> comments/asserts.

Thanks for the further clarification.

-Qiuxu

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ