[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20241021064321.3440-1-mihai.sain@microchip.com>
Date: Mon, 21 Oct 2024 09:43:21 +0300
From: Mihai Sain <mihai.sain@...rochip.com>
To: <richard.genoud@...tlin.com>, <gregkh@...uxfoundation.org>,
<jirislaby@...nel.org>, <nicolas.ferre@...rochip.com>,
<alexandre.belloni@...tlin.com>, <claudiu.beznea@...on.dev>,
<linux-kernel@...r.kernel.org>, <linux-serial@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>
CC: Mihai Sain <mihai.sain@...rochip.com>
Subject: [RFC PATCH] tty: atmel_serial: Use devm_platform_ioremap_resource()
Simplify the request port function by using a single call
to devm_platform_ioremap_resource().
This will also enhance the printing from /proc/iomem:
cat /proc/iomem | grep flexcom ; cat /proc/iomem | grep serial
f0004000-f00041ff : f0004000.flexcom flexcom@...04000
f8020000-f80201ff : f8020000.flexcom flexcom@...20000
f0004200-f00043ff : f0004200.serial serial@200
f8020200-f80203ff : f8020200.serial serial@200
fffff200-fffff3ff : fffff200.serial serial@...ff200
Signed-off-by: Mihai Sain <mihai.sain@...rochip.com>
---
drivers/tty/serial/atmel_serial.c | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
index 09b246c9e389..e1107f14ec98 100644
--- a/drivers/tty/serial/atmel_serial.c
+++ b/drivers/tty/serial/atmel_serial.c
@@ -2419,17 +2419,11 @@ static void atmel_release_port(struct uart_port *port)
static int atmel_request_port(struct uart_port *port)
{
struct platform_device *mpdev = to_platform_device(port->dev->parent);
- int size = resource_size(mpdev->resource);
-
- if (!request_mem_region(port->mapbase, size, "atmel_serial"))
- return -EBUSY;
if (port->flags & UPF_IOREMAP) {
- port->membase = ioremap(port->mapbase, size);
- if (port->membase == NULL) {
- release_mem_region(port->mapbase, size);
- return -ENOMEM;
- }
+ port->membase = devm_platform_ioremap_resource(mpdev, 0);
+ if (IS_ERR(port->membase))
+ return PTR_ERR(port->membase);
}
return 0;
base-commit: 42f7652d3eb527d03665b09edac47f85fb600924
--
2.47.0
Powered by blists - more mailing lists