linux-kernel - Re: [POC 1/6] irq & spin_lock: Add counted interrupt disabling/enabling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202410211410.nrFYq3s2-lkp@intel.com>
Date: Mon, 21 Oct 2024 15:04:39 +0800
From: kernel test robot <lkp@...el.com>
To: Boqun Feng <boqun.feng@...il.com>, Thomas Gleixner <tglx@...utronix.de>
Cc: oe-kbuild-all@...ts.linux.dev, Dirk Behme <dirk.behme@...il.com>,
	Lyude Paul <lyude@...hat.com>, rust-for-linux@...r.kernel.org,
	Danilo Krummrich <dakr@...hat.com>, airlied@...hat.com,
	Ingo Molnar <mingo@...hat.com>, will@...nel.org,
	Waiman Long <longman@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>, linux-kernel@...r.kernel.org,
	Miguel Ojeda <ojeda@...nel.org>,
	Alex Gaynor <alex.gaynor@...il.com>, wedsonaf@...il.com,
	Gary Guo <gary@...yguo.net>,
	Björn Roy Baron <bjorn3_gh@...tonmail.com>,
	Benno Lossin <benno.lossin@...ton.me>,
	Andreas Hindborg <a.hindborg@...sung.com>, aliceryhl@...gle.com,
	Trevor Gross <tmgross@...ch.edu>, Boqun Feng <boqun.feng@...il.com>
Subject: Re: [POC 1/6] irq & spin_lock: Add counted interrupt
 disabling/enabling

Hi Boqun,

kernel test robot noticed the following build errors:

[auto build test ERROR on tip/locking/core]
[also build test ERROR on linus/master v6.12-rc4 next-20241018]
[cannot apply to rust/rust-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Boqun-Feng/irq-spin_lock-Add-counted-interrupt-disabling-enabling/20241018-135435
base:   tip/locking/core
patch link:    https://lore.kernel.org/r/20241018055125.2784186-2-boqun.feng%40gmail.com
patch subject: [POC 1/6] irq & spin_lock: Add counted interrupt disabling/enabling
config: openrisc-allnoconfig (https://download.01.org/0day-ci/archive/20241021/202410211410.nrFYq3s2-lkp@intel.com/config)
compiler: or1k-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241021/202410211410.nrFYq3s2-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410211410.nrFYq3s2-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from include/linux/sched.h:2140,
                    from arch/openrisc/kernel/asm-offsets.c:23:
   include/linux/spinlock.h: In function 'spin_lock_irq_disable':
>> include/linux/spinlock.h:275:41: error: implicit declaration of function '_raw_spin_lock_irq_disable'; did you mean 'raw_spin_lock_irq_disable'? [-Wimplicit-function-declaration]
     275 | #define raw_spin_lock_irq_disable(lock) _raw_spin_lock_irq_disable(lock)
         |                                         ^~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/spinlock.h:383:9: note: in expansion of macro 'raw_spin_lock_irq_disable'
     383 |         raw_spin_lock_irq_disable(&lock->rlock);
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/spinlock.h: In function 'spin_unlock_irq_enable':
>> include/linux/spinlock.h:279:49: error: implicit declaration of function '_raw_spin_unlock_irq_enable'; did you mean 'raw_spin_unlock_irq_enable'? [-Wimplicit-function-declaration]
     279 | #define raw_spin_unlock_irq_enable(lock)        _raw_spin_unlock_irq_enable(lock)
         |                                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/spinlock.h:413:9: note: in expansion of macro 'raw_spin_unlock_irq_enable'
     413 |         raw_spin_unlock_irq_enable(&lock->rlock);
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~
   make[3]: *** [scripts/Makefile.build:102: arch/openrisc/kernel/asm-offsets.s] Error 1
   make[3]: Target 'prepare' not remade because of errors.
   make[2]: *** [Makefile:1203: prepare0] Error 2
   make[2]: Target 'prepare' not remade because of errors.
   make[1]: *** [Makefile:224: __sub-make] Error 2
   make[1]: Target 'prepare' not remade because of errors.
   make: *** [Makefile:224: __sub-make] Error 2
   make: Target 'prepare' not remade because of errors.


vim +275 include/linux/spinlock.h

   273	
   274	#define raw_spin_lock_irq(lock)		_raw_spin_lock_irq(lock)
 > 275	#define raw_spin_lock_irq_disable(lock)	_raw_spin_lock_irq_disable(lock)
   276	#define raw_spin_lock_bh(lock)		_raw_spin_lock_bh(lock)
   277	#define raw_spin_unlock(lock)		_raw_spin_unlock(lock)
   278	#define raw_spin_unlock_irq(lock)	_raw_spin_unlock_irq(lock)
 > 279	#define raw_spin_unlock_irq_enable(lock)	_raw_spin_unlock_irq_enable(lock)
   280	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki