linux-kernel - Re: [RFC PATCH] tty: atmel_serial: Use devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2024102148-stamp-isolation-ae90@gregkh>
Date: Mon, 21 Oct 2024 09:24:57 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Mihai.Sain@...rochip.com
Cc: richard.genoud@...tlin.com, jirislaby@...nel.org,
	Nicolas.Ferre@...rochip.com, alexandre.belloni@...tlin.com,
	claudiu.beznea@...on.dev, linux-kernel@...r.kernel.org,
	linux-serial@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [RFC PATCH] tty: atmel_serial: Use
 devm_platform_ioremap_resource()

On Mon, Oct 21, 2024 at 07:16:31AM +0000, Mihai.Sain@...rochip.com wrote:
> > From: Greg KH <gregkh@...uxfoundation.org>
> > Sent: Monday, October 21, 2024 10:00 AM
> > To: Mihai Sain - M19926 <Mihai.Sain@...rochip.com>
> > Cc: richard.genoud@...tlin.com; jirislaby@...nel.org; Nicolas Ferre - M43238
> > <Nicolas.Ferre@...rochip.com>; alexandre.belloni@...tlin.com;
> > claudiu.beznea@...on.dev; linux-kernel@...r.kernel.org; linux-
> > serial@...r.kernel.org; linux-arm-kernel@...ts.infradead.org
> > Subject: Re: [RFC PATCH] tty: atmel_serial: Use
> > devm_platform_ioremap_resource()
> > 
> > On Mon, Oct 21, 2024 at 09:43:21AM +0300, Mihai Sain wrote:
> > > Simplify the request port function by using a single call to
> > > devm_platform_ioremap_resource().
> > >
> > > This will also enhance the printing from /proc/iomem:
> > >
> > > cat /proc/iomem | grep flexcom ; cat /proc/iomem | grep serial
> > >
> > > f0004000-f00041ff : f0004000.flexcom flexcom@...04000
> > > f8020000-f80201ff : f8020000.flexcom flexcom@...20000
> > > f0004200-f00043ff : f0004200.serial serial@200 f8020200-f80203ff :
> > > f8020200.serial serial@200 fffff200-fffff3ff : fffff200.serial
> > > serial@...ff200
> > >
> > > Signed-off-by: Mihai Sain <mihai.sain@...rochip.com>
> > > ---
> > >  drivers/tty/serial/atmel_serial.c | 12 +++---------
> > >  1 file changed, 3 insertions(+), 9 deletions(-)
> > 
> > Why is this a rfc?  What needs to be done before you want it merged?
> 
> I used the rfc tag in order to get the feedback from you and all stakeholders.

You need to ask for the feedback you are looking for, we don't know what
you feel is wrong here.

> If the modifications are OK for you I will send a new patch without rfc tag.

As we are drowning in real patches to review, I almost always just
ignore RFC patches as I know that means that the submitter feels there
is still more work to be done.  So please always take that in mind.
Please ask for reviews from other developers in your company if you feel
it is not ready for our review.

thanks,

greg k-h