linux-kernel - Re: [PATCH] i2c: designware: Add ACPI HID for DWAPB I2C controller on Fujitsu MONAKA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZxYQDSCpo8n4g3jM@smile.fi.intel.com>
Date: Mon, 21 Oct 2024 11:25:49 +0300
From: 'Andy Shevchenko' <andriy.shevchenko@...ux.intel.com>
To: "Yoshihiro Furudera (Fujitsu)" <fj5100bi@...itsu.com>
Cc: Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	Jan Dabros <jsd@...ihalf.com>, Andi Shyti <andi.shyti@...nel.org>,
	"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] i2c: designware: Add ACPI HID for DWAPB I2C controller
 on Fujitsu MONAKA

On Mon, Oct 21, 2024 at 07:22:55AM +0000, Yoshihiro Furudera (Fujitsu) wrote:
> > On Fri, Oct 18, 2024 at 01:58:26AM +0000, Yoshihiro Furudera wrote:

...

> > Also please give more details:
> > 1) is this ID already present in the wild
> >    (in the products that one may just go and buy)?
> > if so, mention the example of the product.
> 
> Not available at this time.
> It is planned to be implemented in the MONAKA server
> scheduled for shipment in 2027.

So, summarize that in a short sentence, like "This will be used in the MONAKA
server scheduled for shipment in 2027."

> > 2) provide an excerpt from DSDT for the Device object that uses this _HID.
> 
> The DSDT information obtained when verified using
> an in-house simulator is presented below.

Just strip it to the only significant parts, see below

     Device (SMB0)
     {
         Name (_HID, "FUJI200B")  // _HID: Hardware ID
         Name (_UID, Zero)  // _UID: Unique ID
         ...
         Name (_CRS, ResourceTemplate ()
         {
             Memory32Fixed (ReadWrite,
                 0x2A4B0000,         // Address Base
                 0x00010000,         // Address Length
                 )
             Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive, ,, )
             {
                 0x00000159,
             }
         })
         ...
     }

...

Hmm... Why Device object is called SMB0, are you sure it's the correct one?

-- 
With Best Regards,
Andy Shevchenko